[PATCH] libata-core: fix kernel-doc warning

2008-02-22 Thread Randy Dunlap
From: Randy Dunlap <[EMAIL PROTECTED]> Fix libata-core kernel-doc warning: Warning(linux-2.6.25-rc2-git6//drivers/ata/libata-core.c:168): No description found for parameter 'ap' Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]> --- drivers/ata/libata-core.c |2 +- 1 fil

[PATCH] libata: fix kernel-doc parameter warning

2008-02-19 Thread Randy Dunlap
From: Randy Dunlap <[EMAIL PROTECTED]> Fix libata kernel-doc parameter: Warning(linux-2.6.25-rc2-git3//drivers/ata/libata-scsi.c:845): No description found for parameter 'rq' Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]> --- drivers/ata/libata-scsi.c |2 +- 1 fil

Re: [PATCH 03/12] ide: add ide-4drives host driver

2008-02-16 Thread Randy Dunlap
On Sat, 16 Feb 2008 17:39:11 +0100 Bartlomiej Zolnierkiewicz wrote: > CONFIG_BLK_DEV_4DRIVES deserves its own host driver: > > * Add drivers/ide/legacy/ide-4drives.c and move "4drives" support there. > > * Add ide-4drives.o in the link order after all other legacy host > drivers enabled by "id

Re: [PATCH 3/4] printk: implement merging printk

2008-01-15 Thread Randy Dunlap
On Wed, 16 Jan 2008 10:00:09 +0900 Tejun Heo wrote: > --- > include/linux/kernel.h | 71 > kernel/printk.c| 215 > > 2 files changed, 286 insertions(+), 0 deletions(-) > > diff --git a/include/linux/kernel.h b/include

Re: [PATCHSET] printk: implement printk_header() and merging printk

2008-01-15 Thread Randy Dunlap
On Wed, 16 Jan 2008 10:00:06 +0900 Tejun Heo wrote: > Hello, all. > > This patchset implements printk_header() and mprintk - merging printk > - to make printing multiline messages and assembling message > piece-by-piece easier. > > In a nutshell, printk_header() lets you do the following atomica

Re: [PATCH 4/4] libata: make libata use printk_header() and mprintk

2008-01-15 Thread Randy Dunlap
On Wed, 16 Jan 2008 10:00:10 +0900 Tejun Heo wrote: > Reimplement libata printk helpers using printk_header, implement > helpers to initialize mprintk and use mprintk during device > configuration and EH reporting. > > This fixes various formatting related problems of libata messages such > as mi

Re: Peculiar out-of-sync boot log lines

2007-12-01 Thread Randy Dunlap
On Sat, 1 Dec 2007 22:59:35 +0100 Bartlomiej Zolnierkiewicz wrote: > Thanks for reporting/debugging it guys! > > > Something in there needs to insert a '\n' before the "skipping word" > > message. > > Since it doesn't do that right now, the KERN_DEBUG string appears as "<7>" > > This seems like

Re: [PATCH 2/2] ide-scsi: use print_hex_dump from

2007-11-26 Thread Randy Dunlap
Matthew Wilcox wrote: On Mon, Nov 26, 2007 at 04:37:50PM +0800, rae l wrote: I know this is different from the original hexdump in ide-scsi.c, I just want to tell someone that there's a good implementation of hexdump in kernel.h, and I think the default KERN_DEBUG and print_hex_dump is more info

Re: [BUG] New Kernel Bugs

2007-11-14 Thread Randy Dunlap
On Wed, 14 Nov 2007 21:37:37 +0100 Ingo Molnar wrote: > ok, then you conceded it by not replying to it? good ;-) No, I don't intend to carry on this discussion, but I appreciate the smiley. --- ~Randy - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message

Re: [BUG] New Kernel Bugs

2007-11-14 Thread Randy Dunlap
On Wed, 14 Nov 2007 21:16:39 +0100 Ingo Molnar wrote: > countered by the underlined sentences above, just in case you missed it. I didn't miss your claim. --- ~Randy - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL PROTECTED] More majord

Re: [BUG] New Kernel Bugs

2007-11-14 Thread Randy Dunlap
On Wed, 14 Nov 2007 15:08:47 +0100 Ingo Molnar wrote: > > * Randy Dunlap <[EMAIL PROTECTED]> wrote: > > > > (and this is in no way directed at the networking folks - it holds > > > for all of us. I have one main complaint about networking: the > &g

Re: [BUG] New Kernel Bugs

2007-11-13 Thread Randy Dunlap
On Tue, 13 Nov 2007 09:33:21 -0600 James Bottomley wrote: > On Tue, 2007-11-13 at 03:15 -0800, Andrew Morton wrote: > > > > > SCSI== > > > > > > qla2xxx: driver initialization does not complete when booting with > > > Port connected

Re: [BUG] New Kernel Bugs

2007-11-13 Thread Randy Dunlap
On Tue, 13 Nov 2007 14:40:29 +0100 Ingo Molnar wrote: > > * Andrew Morton <[EMAIL PROTECTED]> wrote: > > > > > Do you believe that our response to bug reports is adequate? > > > > > > Do you feel that making us feel and look like shit helps? > > > > That doesn't answer my question. > > > > Se

[PATCH] libata: fix kernel-doc param name

2007-10-18 Thread Randy Dunlap
From: Randy Dunlap <[EMAIL PROTECTED]> Fix libata kernel-doc parameter name. Warning(linux-2.6.23-git13//drivers/ata/libata-core.c:1415): No description found for parameter 'sgl' Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]> --- drivers/ata/libata-core.c |2

[PATCH 2/4] docbook: fix libata content

2007-10-15 Thread Randy Dunlap
From: Randy Dunlap <[EMAIL PROTECTED]> Fix libata docbook warnings. Warning(linux-2.6.23-git8//drivers/ata/libata-scsi.c:3251): No description found for parameter 'dev' Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]> --- drivers/ata/libata-scsi.c |2 +- 1 file chan

Re: sata & scsi suggestion for make menuconfig

2007-09-08 Thread Randy Dunlap
On Sat, 08 Sep 2007 18:44:46 +0200 Stefan Richter wrote: > Randy Dunlap wrote: > > Stefan Richter wrote: > >> I am not a friend of 'select', but maybe the following actually helps. > ... > > The problem with 'select' here is that it will enable BLK_

Re: sata & scsi suggestion for make menuconfig

2007-09-08 Thread Randy Dunlap
Stefan Richter wrote: (added Cc linux-ide) Folkert van Heusden wrote: A popup makes some sense, but I don't know if menuconfig knows how to do popup warnings... and it needs to be done for all *configs, not just menuconfig. Maybe add a new type? How about comment "Note: 'SCSI disk support' is

[PATCH] pata_it821x: fix section mismatch warning

2007-06-25 Thread Randy Dunlap
From: Randy Dunlap <[EMAIL PROTECTED]> Fix section mismatch when CONFIG_HOTPLUG=n (but functions are used for resume): WARNING: drivers/ata/pata_it821x.o(.text+0x3f): Section mismatch: reference to .init.text: (between 'it821x_reinit_one' and 'it821x_program_udma&#

Re: sd_resume redundant? [was: [PATCH] libata: implement ata_wait_after_reset()]

2007-05-20 Thread Randy Dunlap
On Sun, 20 May 2007 11:45:03 -0600 Robert Hancock wrote: > Indan Zupancic wrote: > >>> Everything seems to work fine without sd_resume(), so why is it needed? > >> Because not all disks spin up without being told to do so and like it or > >> not spinning disks up on resume is the default behavior.

Re: [patch 1/7] libata: check for AN support

2007-05-10 Thread Randy Dunlap
On Wed, 9 May 2007 22:09:52 -0700 Andrew Morton wrote: > On Wed, 9 May 2007 16:38:09 -0700 Kristen Carlson Accardi <[EMAIL PROTECTED]> > wrote: > > > /** > > + * ata_dev_set_AN - Issue SET FEATURES - SATA FEATURES > > + * with sector count set to indicate > > + *

[PATCH] libata: fix kernel-doc parameters

2007-05-01 Thread Randy Dunlap
From: Randy Dunlap <[EMAIL PROTECTED]> Warning(linux-2.6.21-git4//drivers/ata/libata-core.c:904): No description found for parameter 'new_sectors' Warning(linux-2.6.21-git4//drivers/ata/libata-core.c:941): No description found for parameter 'new_sectors' Signed-of

[RFC/PATCH -mm] add pci_try_set_mwi

2007-04-16 Thread Randy Dunlap
FOO on error (presently unimplemented) > > - review callers > > - remove __must_check > > ? From: Randy Dunlap <[EMAIL PROTECTED]> As suggested by Andrew, add pci_try_set_mwi(), which does not require return-value checking. - add pci_try_set_mwi() without __must_check - ma

Re: [PATCH] IDE: fix PCI must_checks

2007-04-05 Thread Randy Dunlap
Andrew Morton wrote: On Thu, 5 Apr 2007 21:16:09 +0100 Alan Cox <[EMAIL PROTECTED]> wrote: pci_set_mwi() is an advisory thing, and on certain platforms it might fail to set the cacheline size to the desired number. This is not a fatal error and the driver can successfully run at a lesser perfo

Re: [PATCH] HPA support: Revised patch

2007-04-05 Thread Randy Dunlap
On Thu, 5 Apr 2007 14:13:52 +0100 Alan Cox wrote: > This one should fix the problems with slave devices and the Macintosh hang s/Performa/Perform/g > +/** > + * ata_read_native_max_address_ext - LBA48 native max query > + * @dev: Device to query > + * > + * Performa an LBA48 size que

[PATCH] IDE: fix PCI must_checks

2007-04-04 Thread Randy Dunlap
From: Randy Dunlap <[EMAIL PROTECTED]> Check PCI interface function results for errors in drivers/ide/pci. drivers/ide/pci/cs5530.c:244: warning: ignoring return value of 'pci_set_mwi', declared with attribute warn_unused_result drivers/ide/pci/sc1200.c:397: warning: ignoring

[PATCH] ATA: fix PCI must_checks

2007-04-04 Thread Randy Dunlap
From: Randy Dunlap <[EMAIL PROTECTED]> Check PCI interface functions results for PATA/SATA drivers. Fixes these warnings: drivers/ata/pata_cs5530.c:284: warning: ignoring return value of 'pci_set_mwi', declared with attribute warn_unused_result Signed-off-by: Randy Dunlap &

Re: [3/6] 2.6.21-rc4: known regressions

2007-03-28 Thread Randy Dunlap
On Wed, 28 Mar 2007 20:04:57 +0200 Michael S. Tsirkin wrote: > > Subject: first disk access after resume takes several minutes > > ('date' does not advance after resume from RAM, CONFIG_NO_HZ=n) > > References : http://lkml.org/lkml/2007/3/8/117 > > http://lkml.org/lk

Re: HPA patches

2007-03-23 Thread Randy Dunlap
On Fri, 23 Mar 2007 20:08:19 + Alan Cox wrote: > > > +static int ata_ignore_hpa = 0; > > > > Don't init to 0. Not needed, bloats binary files. > > It'll be one for the final release 8) > > > > +module_param_named(ignore_hpa, ata_ignore_hpa, int, 0644); > > > +MODULE_PARM_DESC(ignore_hpa, "

Re: HPA patches

2007-03-23 Thread Randy Dunlap
On Fri, 23 Mar 2007 19:13:21 + Alan Cox wrote: > For reference this is what I am currently using with 2.6.21-rc4-mm1 and > it is working for all my test cases so far: Its basically Kyle's patch > with a libata switch to turn it on/off and some minor fixups from > the original patch as posted >

[PATCH] libata: kernel-doc fix

2007-03-16 Thread Randy Dunlap
From: Randy Dunlap <[EMAIL PROTECTED]> Warning(linux-2621-rc3g7/drivers/ata/libata-core.c:842): No description found for parameter 'unknown' Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]> --- drivers/ata/libata-core.c |2 +- 1 file changed, 1 insertion(+), 1 delet

[PATCH] SATA: use NULL for ptrs

2007-02-13 Thread Randy Dunlap
From: Randy Dunlap <[EMAIL PROTECTED]> Fix sparse warnings in SATA: drivers/ata/sata_sil.c:342:9: warning: Using plain integer as NULL pointer drivers/ata/sata_mv.c:2056:55: warning: Using plain integer as NULL pointer Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]> --- drivers/a

Re: [PATCH 2.6.19-rc1] Toshiba TC86C001 IDE driver

2006-12-12 Thread Randy Dunlap
Sergei Shtylyov wrote: Hello. Randy Dunlap wrote: Behold! This is the driver for the Toshiba TC86C001 GOKU-S IDE controller, completely reworked from the original brain-damaged Toshiba's 2.4 version. This single channel UltraDMA/66 controller is very simple in programming, yet To

Re: [PATCH 2.6.19-rc1] Toshiba TC86C001 IDE driver

2006-12-12 Thread Randy Dunlap
On Wed, 13 Dec 2006 01:48:34 +0300 Sergei Shtylyov wrote: > Behold! This is the driver for the Toshiba TC86C001 GOKU-S IDE controller, > completely reworked from the original brain-damaged Toshiba's 2.4 version. > > This single channel UltraDMA/66 controller is very simple in programming, yet >

Re: -mm merge plans for 2.6.20

2006-12-06 Thread Randy Dunlap
On Thu, 07 Dec 2006 03:19:40 +0800 Conke Hu wrote: > On Mon, 2006-12-04 at 21:41 -0800, Andrew Morton wrote: > > On Mon, 04 Dec 2006 23:56:42 -0500 > > Jeff Garzik <[EMAIL PROTECTED]> wrote: > > > > > Andrew Morton wrote: > > > > via-pata-controller-xfer-fixes.patch > > > > via-pata-controller-xf

[PATCH] ata/kconfig: Re: Why SCSI module needed for PCI-IDE ATA only disks ?

2006-12-05 Thread Randy Dunlap
On Tue, 05 Dec 2006 21:46:54 -0500 Ed Sweetman wrote: -ETOOMANYWORDS && -ENOPATCH, so here is one to consider. Help text can also be added. This is similar to what USB storage already does. --- From: Randy Dunlap <[EMAIL PROTECTED]> Provide more clues about SCSI config options t