Tejun Heo wrote:
Robert Hancock wrote:
Tejun Heo wrote:
Michael Sedkowski wrote:
Hmmm... If the problem only shows up on nx6325, it might be that
ACPI is
pulling unnecessary stunt. Please apply the attached patch and report
when the disk spins down and up.
Disk spins down on "Pre-shu
here is
nothing to flush, and the kernel does its own standby, this could cause
an extra spinup/down..
--
Robert Hancock Saskatoon, SK, Canada
To email, remove "nospam" from [EMAIL PROTECTED]
Home Page: http://www.roberthancock.com/
-
To unsubscribe from this list: send the line
looking at error reports. Some bits that drivers/ide
decoded are not decoded here, since the bits are either command-dependent
or obsolete, and properly parsing them would add too much complexity.
Signed-off-by: Robert Hancock <[EMAIL PROTECTED]>
---
Rebased to apply to 2.6.23-r
ller but work on others..
Also I haven't noticed any SMART problems on my machine with ADMA
enabled.. maybe it's drive or motherboard dependent?
--
Robert Hancock Saskatoon, SK, Canada
To email, remove "nospam" from [EMAIL PROTECTED]
Home Page: http://www.roberthancock.c
can safely ignore?
I don't think the NVIDIA page is correct. AFAIK all nForce4 chipsets
support SATA 3Gbps transfer speeds.
The kernel doesn't have any control over the default speed chosen by the
controller in any case (though it can force it down to a lower speed).
--
Robe
Jeff Garzik wrote:
Kuan Luo wrote:
@@ -1714,3 +2761,6 @@ module_init(nv_init);
module_exit(nv_exit);
module_param_named(adma, adma_enabled, bool, 0444);
MODULE_PARM_DESC(adma, "Enable use of ADMA (Default: true)");
+module_param_named(ncq, ncq_enabled, bool, 0444);
+MO
C errors or
timeouts), so this should be safe. We just had better be sure that the
speed we give it is valid, since there is no sane way for the function
to indicate failure. (Thus the problem with the "cram in all possible
values to see what it supports" strategy for determining mode
The sata_nv driver was missing the change_queue_depth hook in the SCSI host
template which the other NCQ-capable libata drivers had. This made it impossible
to change the queue depth by user request. Add this in.
Signed-off-by: Robert Hancock <[EMAIL PROTECTED]>
--- linux-2.6.22-rc6-mm1/d
aching Hitachi to the ID strings
now.. In the past it hasn't seemed to have been Hitachi's (and IBM's
before that) practice to have it there, but maybe they see the advantage
of being able to figure out who made the drive now :-)
--
Robert Hancock Saskatoon, SK, Canada
To ema
ORKAGE_NONCQ, },
/* Devices with NCQ limits */
Is that the right ID string? Strange that that one has Hitachi at the
front and the others don't..
--
Robert Hancock Saskatoon, SK, Canada
To email, remove "nospam" from [EMAIL PROTECTED]
Home Page: http://www.roberthanc
bug, the driver doing
something the controller doesn't expect..
Does this drive actually support NCQ? I can't tell from this part of the
log.
--
Robert Hancock Saskatoon, SK, Canada
To email, remove "nospam" from [EMAIL PROTECTED]
Home Page: http://www.roberthancock.
ns for actually outstanding commands that
aren't actually completed yet..)
--
Robert Hancock Saskatoon, SK, Canada
To email, remove "nospam" from [EMAIL PROTECTED]
Home Page: http://www.roberthancock.com/
-
To unsubscribe from this list: send the line "unsubscribe linux
s a simple "go"
I/O to start a transaction, immediately after the previous one ends.
Jeff
Theoretically NVIDIA nForce4 ADMA could likely do this as well, as it
seems to allow chaining up multiple commands to execute in succession
(assuming they're not NCQ)..
--
Robert Hanco
ble.
> > Here's a rediffed version of the same.
>
> Please update libata as well when you udpate the blacklists.
Sure, point me at the table(s) ?
Dave
ata_device_blacklist in drivers/ata/libata-core.c
--
Robert Hancock Saskatoon, SK, Canada
To email, remo
ng _STM followed by
executing _GTF and running those commands.
This won't handle the case where the driver is loaded after the system
was already suspended to RAM and resumed, however I don't know exactly
how one could handle that in this situation..
--
Robert Hancock Saskatoon, S
oot-up controller registers, or by calling GTM). I imagine
this is what the Windows default IDE driver is doing (just using the
boot-up mode and feeding it back using GTM/STM on suspend/resume cycles).
--
Robert Hancock Saskatoon, SK, Canada
To email, remove "nospam" from [EMA
Randy Dunlap wrote:
On Sun, 20 May 2007 11:45:03 -0600 Robert Hancock wrote:
Indan Zupancic wrote:
Everything seems to work fine without sd_resume(), so why is it needed?
Because not all disks spin up without being told to do so and like it or
not spinning disks up on resume is the default
es 64-bit DMA addresses (where
supported by platform) and eliminates the annoying 64k DMA boundary
found in legacy PCI IDE BMDMA engines.
Looks like it doesn't allow 64-bit DMA addresses, it only gets rid of
the 64K boundary limitation.
--
Robert Hancock Saskatoon, SK, Canada
To ema
ct
this case we should raise an HSM violation which will disable NCQ on
this drive if it happens repeatedly. See the code in ahci.c in
ahci_host_intr.
This comment still applies:
Additional/general comments:
Think you need some code to handle suspend and resume (re-enable SATA
MMIO space, et
Peer Chen wrote:
Add the Software NCQ support to sata_nv.c for MCP51/MCP55/MCP61 SATA
controller.
This patch base on sata_nv.c file from kernel 2.6.22-rc1
See attachment for the patch.
Signed-off-by: Kuan Luo <[EMAIL PROTECTED]>
Signed-off-by: Peer Chen <[EMAIL PROTECTED]>
Good to finally s
of this patch.
Signed-off-by: Robert Hancock <[EMAIL PROTECTED]>
--- linux-2.6.21.1/drivers/ata/libata-eh.c 2007-04-27 15:49:26.0
-0600
+++ linux-2.6.21.1edit/drivers/ata/libata-eh.c 2007-05-14 17:38:35.0
-0600
@@ -1523,6 +1523,27 @@ static void ata_eh_report(struct a
rt SMART
Error Counter logging not supported
[GLTSD (Global Logging Target Save Disable) set. Enable Save with '-S on']
Device does not support Self Test logging
Sounds like SMART is likely disabled on that drive. You can try doing
"smartctl -s on /dev/sda" and see if that w
sing it to just toss these commands? CCing linux-ide in case anyone
knows what would cause this.
--
Robert Hancock Saskatoon, SK, Canada
To email, remove "nospam" from [EMAIL PROTECTED]
Home Page: http://www.roberthancock.com/
-
To unsubscribe from this list: send the line "un
Tejun Heo wrote:
Chuck Ebbert wrote:
Robert Hancock wrote:
+ ehc->i.serror & SERR_TRANS_ST_ERROR ? "TransStatTransErr "
: "",
+ ehc->i.serror & SERR_UNRECOG_FIS ? "UnrecogFIS " : "",
+ ehc->i.serror & SERR
ases, like oops
output. With libata errors, if they're at the console (which they'd have
to be to see these messages), unless something has actually caused a
panic the scrollback buffer should still be functional and they'd be
able to see the entire output..
--
Robert Hancock
The human readable
form is also a bit cryptic and can get quite long. So, mild NACK from me.
It certainly seems useful when debugging hotplug issues or random SATA
problems which end up being caused by communication problems. Without
this output, Joe User stands no chance of figuring out
looking at error
reports. Some bits that drivers/ide decoded are not decoded here, since the bits
are either command-dependent or obsolete, and properly parsing them would add
too much complexity.
Signed-off-by: Robert Hancock <[EMAIL PROTECTED]>
--- linux-2.6.21.1/drivers/ata/libat
x27;t check any
ADMA status if the port has ADMA switched off because of an ATAPI device, and
it also checks to see if any ADMA interrupt has been raised even when we are in
port-register mode.
Signed-off-by: Robert Hancock <[EMAIL PROTECTED]>
--- linux-2.6.21.1/drivers/ata/sata_nv.c
boot.
Sometimes I even have to completely power down the machine to be able to
boot again.
Power problems would be another possibility..
--
Robert Hancock Saskatoon, SK, Canada
To email, remove "nospam" from [EMAIL PROTECTED]
Home Page: http://www.roberthancock.com/
-
To unsubscribe from
r than making people pore
through the SATA spec and count bits). First thing you should try is
replacing the SATA cable to that drive.
--
Robert Hancock Saskatoon, SK, Canada
To email, remove "nospam" from [EMAIL PROTECTED]
Home Page: http://www.roberthancock.com/
-
To unsubs
gging these problems. Though, later kernels are supposed to
switch it off automatically after too many errors..
--
Robert Hancock Saskatoon, SK, Canada
To email, remove "nospam" from [EMAIL PROTECTED]
Home Page: http://www.roberthancock.com/
-
To unsubscribe from this list: send the
Jeff Garzik wrote:
[EMAIL PROTECTED] wrote:
From: Robert Hancock <[EMAIL PROTECTED]>
Some debug output in the ADMA error_handler function was removed
recently,
but it may be useful in certain cases, like NCQ commands timing out. Add
it back in, but make it a bit more intelligent so t
Tejun Heo wrote:
libata didn't use to spin down disks properly on shutdown and userland
shutdown(8) worked around it by synchronizing cache and spinning down
by itself before telling the kernel to shutdown. However, this
userland work around collides with libata shutdown because some drives
spin
tom of the drive and controller just not getting along,
but you might want to try a different SATA cable as well.
--
Robert Hancock Saskatoon, SK, Canada
To email, remove "nospam" from [EMAIL PROTECTED]
Home Page: http://www.roberthancock.com/
-
To unsubscribe from this list: send t
ding back a result taskfile (which
can't be done in ADMA mode). The patch in libata-dev which I mentioned
in another email will ensure that we don't try to use ADMA for such
commands, so this patch should not be needed.
--
Robert Hancock Saskatoon, SK, Canada
To email, remove "nos
- Original Message -
From: Kyle McMartin <[EMAIL PROTECTED]>
Date: Friday, April 13, 2007 10:47 am
Subject: Re: [PATCH] libata: HPA support
> [Adding Robert to the CC incase he doesn't follow linux-ide]
>
> On Fri, Apr 13, 2007 at 12:33:41PM -0400, Kyle McMartin wrote:
> > On Fri, Apr 13,
Jeff Garzik wrote:
Robert Hancock wrote:
This adds some NCQ blacklist entries taken from the Silicon Image
3124/3132
Windows driver .inf files. There are some confirming reports of problems
with these drives under Linux (for example
http://lkml.org/lkml/2007/3/4/178)
so let's disable N
This adds some NCQ blacklist entries taken from the Silicon Image 3124/3132
Windows driver .inf files. There are some confirming reports of problems
with these drives under Linux (for example http://lkml.org/lkml/2007/3/4/178)
so let's disable NCQ on these drives.
Signed-off-by: Robert Ha
nd and the controller is still waiting for a
response.
Could be that this is another drive that needs to be added to the NCQ
blacklist, some similar Maxtor models seem to have issues..
--
Robert Hancock Saskatoon, SK, Canada
To email, remove "nospam" from [EMAIL PROTEC
ve
has to be added to the NCQ blacklist.
Max
This does indeed look like a drive side issue to me (the controller is
reporting CPBs with response flags 2 which as far as I can tell
indicates it's still waiting for the drive to complete the request).
--
Robert Hancock Saskatoon, SK, C
en be
able to usefully test?
Yes, you should be able to.
--
Robert Hancock Saskatoon, SK, Canada
To email, remove "nospam" from [EMAIL PROTECTED]
Home Page: http://www.roberthancock.com/
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the bod
Jeff Garzik wrote:
[EMAIL PROTECTED] wrote:
From: Robert Hancock <[EMAIL PROTECTED]>
Reading from the ATA shadow registers while we are in ADMA mode may cause
undefined behavior. Don't read the ATA status register when completing
commands for this reason, it shouldn't
ned-off-by: Robert Hancock <[EMAIL PROTECTED]>
--- linux-2.6.21-rc3-git3/drivers/ata/sata_nv.c 2007-03-08 17:15:25.0
-0600
+++ linux-2.6.21-rc3-git3edit/drivers/ata/sata_nv.c 2007-03-08
17:19:42.0 -0600
@@ -874,8 +874,14 @@
if (status &
result taskfile requested
to execute in ADMA mode, since that requires accessing the shadow registers.
We also still need to override tf_read since libata will read the result
taskfile on a command failure, and we need to go into port register mode
before allowing this.
Signed-off-by: Robert
: spurious interrupt (irq_stat 0x8 active_tag -84148995 sactive 0xf)
Sounds like those are some that we should be blacklisting as well,
unless Eric has a good reason why not (CCing). Can you provide the full
firmware revision strings from those drives, i.e. from "hdparm -I"?
--
Robe
would be more likely to
fit inside the queue..
--
Robert Hancock Saskatoon, SK, Canada
To email, remove "nospam" from [EMAIL PROTECTED]
Home Page: http://www.roberthancock.com/
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of
isn't
outstanding, since the drive may be issuing spurious completions.
Signed-off-by: Robert Hancock <[EMAIL PROTECTED]>
--- linux-2.6.21-rc1edit/drivers/ata/sata_nv.c.prev 2007-02-21
22:17:31.0 -0600
+++ linux-2.6.21-rc1edit/drivers/ata/sata_nv.c 2007-02-21 22:22:14.0
This patch adds in some NCQ blacklist entries taken from the Silicon
Image Windows drivers' .inf files for the 3124 and 3132 controllers.
These entries were marked as ""DisableSataQueueing". Assume these are
in their blacklist for a reason and disable NCQ on these drives.
S
n't support non-NCQ FUA, and
those (especially the latter) seem to be very popular models.
Likely Seagate didn't implement that command since they figured nobody
would use that if they had NCQ..
--
Robert Hancock Saskatoon, SK, Canada
To email, remove "nospam" from [EMAIL PR
.
The only thing we need to override as far as ADMA and BMDMA is the
post_internal_cmd callback, where we should only call ata_post_internal_cmd
if we are in port-register mode.
Signed-off-by: Robert Hancock <[EMAIL PROTECTED]>
--- linux-2.6.20-git14edit/drivers/ata/sata_nv.c.before_cleanup 2007
311x (since that one is known to have
problems) as well as for ITE821x when in smart mode.
Signed-off-by: Robert Hancock <[EMAIL PROTECTED]>
---
Any comments on this version? It's essentially what I posted previously
in "libata FUA revisited", except that the default for F
, accessing them will likely result in a cache miss.
Signed-off-by: Robert Hancock <[EMAIL PROTECTED]>
--- linux-2.6.20-git6edit/drivers/ata/sata_nv.c 2007-02-15 22:36:02.0
-0600
+++ linux-2.6.20-git6edit/drivers/ata/sata_nv.c.delayandfixes 2007-02-19
17:00:14.0 -0600
@@ -
This edits the taskfile setup to more closely match the way that libata
sends the taskfile for other controllers. This avoids putting taskfile writes
into the CPB buffer that are not needed according to the taskfile flags.
Signed-off-by: Robert Hancock <[EMAIL PROTECTED]>
--- linux-
We already have code that handles hotplug interrupt indications in ADMA
mode, this turns on the control flag that actually enables these interrupts.
Also fixes some cases in the same functions where a 16-bit register was read
using a readl instead of a readw.
Signed-off-by: Robert Hancock
When error handling occurs with pending commands, output the contents
of the next CPB count and next CPB index registers as well as the others,
since these may be useful for debugging.
Signed-off-by: Robert Hancock <[EMAIL PROTECTED]>
--- linux-2.6.20-git6edit/drivers/ata/sata_nv.c 2007
Clean up the initialization of the CPB and APRD structures so that we
strictly follow the rules for ordering of writes to the CPB flags and
response flags, and prevent duplicate initialization.
Signed-off-by: Robert Hancock <[EMAIL PROTECTED]>
--- linux-2.6.20-git6edit/drivers/ata/sat
This patch series contains several fixes for issues I noticed while
debugging some command timeout problems. None of these proved to be
related to that issue, but they fall into the category of things
we should be doing anyway.
Split into separate patches to ease bisecting in case of issues.
-
ned up somewhat. Also, it's been inadvertently tested (it seems that
pata_amd Nvidia cable detection is broken in current -git..)
Signed-off-by: Robert Hancock <[EMAIL PROTECTED]>
--- linux-2.6.20-git6/drivers/ata/libata-core.c 2007-02-11 17:31:19.0
-0600
+++ linux-2.6.20-g
: Robert Hancock <[EMAIL PROTECTED]>
--- linux-2.6.20-git6edit/drivers/ata/sata_nv.c.before_hacking 2007-02-15
18:19:13.0 -0600
+++ linux-2.6.20-git6edit/drivers/ata/sata_nv.c 2007-02-15 22:36:02.0
-0600
@@ -219,6 +219,7 @@
void __iomem * gen_block;
need
to drain the drive queue before issuing the WRITE/FUA. And at that point
we may as well not use the NCQ command, just go for the regular non-NCQ
FUA write. I think that should be safe.
Aside from the issue above, as I mentioned elsewhere, lots of NCQ drives
don't support non-NCQ FUA
ex to start with. It looks like pata_amd does an
ata_pci_clear_simplex only for certain chip models, maybe this model
needs it as well?
--
Robert Hancock Saskatoon, SK, Canada
To email, remove "nospam" from [EMAIL PROTECTED]
Home Page: http://www.roberthancock.com/
-
To unsubscribe
Jeff Garzik wrote:
Robert Hancock wrote:
It's curious that only the post-cache-flush command is having issues,
and normal NCQ operation seems fine. Maybe it's related to that tag 0
being reused repeatedly?
If you take cache flush out of the equation, what happens when NCQ is
enab
there's something wrong with
the way we are giving the commands to the controller, using the
APPEND register. That's another thing that's not in the ADMA standard.
It's curious that only the post-cache-flush command is having issues,
and normal NCQ operation seems fine. Maybe
Q on it entirely as
obviously little thought or testing went into the implementation..
--
Robert Hancock Saskatoon, SK, Canada
To email, remove "nospam" from [EMAIL PROTECTED]
Home Page: http://www.roberthancock.com/
-
To unsubscribe from this list: send the line "unsubscribe lin
d be nice if you add a comment why the drives are added
for documentation.
Will do shortly. Eric, do you have any info on the blacklisting of that
Maxtor 7B250S0 drive? I would hope that Silicon Image would have a good
reason for blacklisting that one..
--
Robert Hancock S
Robert Hancock wrote:
Given the above, what I'm proposing to do is:
-Remove the blacklisting of Maxtor BANC1G10 firmware for FUA. If we need
to FUA-blacklist any drives this should likely be added to the existing
"horkage" mechanism we now have. However, at this point I don&
BANC1B70
HTS541060G9SA00 MB3OC60D
HTS541080G9SA00 MB4OC60D
HTS541010G9SA00 MBZOC60D
(the latter 3 being Hitachi Travelstar drives)
--
Robert Hancock Saskatoon, SK, Canada
To email, remove "nospam" from [EMAIL PROTECTED]
Home Page: http://www.r
it won't spew at inappropriate times like suspend/resume.
Signed-off-by: Robert Hancock <[EMAIL PROTECTED]>
--- linux-2.6.20-git6/drivers/ata/sata_nv.c 2007-02-11 17:31:19.0
-0600
+++ linux-2.6.20-git6edit/drivers/ata/sata_nv.c 2007-02-11 17:40:48.0
-0600
@@ -1442
ADMA-capable controllers provide a bit in the status register that appears
to indicate that the controller detected an SError condition. Update sata_nv
to detect this and trigger error handling in order to handle the fault.
Signed-off-by: Robert Hancock <[EMAIL PROTECTED]>
--- drive
y. If
the event was something else, then pcim_enable_device complains because
the device was previously enabled and never disabled.
Not sure what the best way to fix this is?
--
Robert Hancock Saskatoon, SK, Canada
To email, remove "nospam" from [EMAIL PROTECTED]
Home Page: http:
her the rate is being limited by the cable
and not the drive or controller.
I haven't tested whether the message actually shows up, as my system
isn't horked in this manner..
Signed-off-by: Robert Hancock <[EMAIL PROTECTED]>
--- linux-2.6.20-rc6-mm3/drivers/ata/libata-core.c
ata_pci_device_do_resume can fail if the PCI device couldn't be re-enabled.
Update sata_nv to propagate the return value from this call and to
not try to do any other resume activities if it fails. Fixes a compile
warning.
Signed-off-by: Robert Hancock <[EMAIL PROTECTED]>
--- linux
o fix that problem,
this is something we should likely be doing in any case.
Signed-off-by: Robert Hancock <[EMAIL PROTECTED]>
--- linux-2.6.20-rc6-mm3/drivers/ata/sata_nv.c 2007-02-04 21:48:25.0
-0600
+++ linux-2.6.20-rc6-mm3edit/drivers/ata/sata_nv.c 2007-02-04
22:13:36.
Stefan Richter wrote:
Robert Hancock wrote:
http://marc.theaimsgroup.com/?t=11692262122
It looks like Tejun's patch essentially does the same thing as mine with
the addition of the control from userspace. There is one exception
though, my patch also does the stop on removal of the
, the main "how-to" page I found had an addendum
that "I gave up on this, it's too hard, I just attach the patches". If
anyone has gotten any new insight..
--
Robert Hancock Saskatoon, SK, Canada
To email, remove "nospam" from [EMAIL PROTECTED]
Home Pa
oes the stop on removal of the SCSI disk (i.e.
writing 1 to its "delete" file in sysfs, what scsiadd -r does). I think
it makes sense if the user selected the disk to be spun down on shutdown
to do it on removal as well, as it is potentially about to be physically
removed/powered down (esp
ds to be set to 0. Without
it the other 9 bytes will contain uninitialized junk.
For the other cleanup changes, though:
Signed-off-by: Robert Hancock <[EMAIL PROTECTED]>
--
Robert Hancock Saskatoon, SK, Canada
To email, remove "nospam" from [EMAIL PROTE
request succeeded but it
didn't actually spin the drive down.
--
Robert Hancock Saskatoon, SK, Canada
To email, remove "nospam" from [EMAIL PROTECTED]
Home Page: http://www.roberthancock.com/
--- linux-2.6.20-rc6nv/drivers/scsi/sd.c2007-01-28 17:00:00.0
-0600
++
he ATA standard says this means
disable the standby timer, which effectively does nothing. Change this
to issue a STANDBY IMMEDIATE command which will actually spin the drive
down. The SAT (SCSI/ATA Translation) standard revision 9 concurs with
this choice.
Signed-off-by: Robert Hancock &l
read it.
Signed-off-by: Robert Hancock <[EMAIL PROTECTED]>
--
Robert Hancock Saskatoon, SK, Canada
To email, remove "nospam" from [EMAIL PROTECTED]
Home Page: http://www.roberthancock.com/
--- linux-2.6.20-rc6nv/drivers/ata/sata_nv.c2007-01-28 17:05:27.0
-0600
ant at this point since libata
already dumps the state of all active commands on errors (and it also
triggers at times when it shouldn't, like when suspending). Take this
out.
Signed-off-by: Robert Hancock <[EMAIL PROTECTED]>
--- linux-2.6.20-rc5/drivers/ata/sata_nv.c 2007-01-12 23:18:08
Robert Hancock wrote:
-In the error_handler function the code would always go through and do
an ADMA channel reset and also dump out the state of all the CPBs. This
reset seems heinous in this situation since we haven't even decided to
reset anything yet. The output seems redundant at
when it shouldn't, like when suspending). Do the
ADMA reset only on hardreset and remove the output.
Signed-off-by: Robert Hancock <[EMAIL PROTECTED]>
--- linux-2.6.20-rc5/drivers/ata/sata_nv.c 2007-01-12 23:18:08.0
-0600
+++ linux-2.6.20-rc5edit/drivers/ata/sata_nv.
Since I've been the one making the most changes in sata_nv lately I
figured I would make some more comments on this patch:
Subject:
RE: [PATCH] SCSI: Add the SGPIO support for sata_nv.c
From:
"Peer Chen" <[EMAIL PROTECTED]>
Date:
Tue, 7 Nov 2006 17:55:11 +0800
To:
"Christoph Hellwig" <[EMAIL PRO
Thoughts from Jeff & company on merging the patch below into libata-dev?
This has been in the -mm tree for over a month now, I haven't heard any
complaints about regressions..
---
From: Robert Hancock <[EMAIL PROTECTED]>
This patch adds the necessary callbacks to support
freed while it could potentially still be
used.
Signed-off-by: Robert Hancock <[EMAIL PROTECTED]>
--- linux-2.6.19-rc6-mm2/drivers/ata/sata_nv.c 2006-12-12 17:49:02.0
-0600
+++ linux-2.6.19-rc6-mm2admafix/drivers/ata/sata_nv.c 2006-12-11
22:15:58.0 -0600
@@ -49,7 +
end/resume change for sata_nv introduced a potential bug where
the hpriv structure could be used after it was freed in nv_remove_one.
Fix that.
Signed-off-by: Robert Hancock <[EMAIL PROTECTED]>
---
Robert Hancock Saskatoon, SK, Canada
To email, remove "nospam" from [EMAIL
issed them.. It would be nice to get this support in,
those are the last NVIDIA chipsets which have NCQ support (apparently)
that don't support it under Linux. Even just the hardware docs would be
useful..
---
Robert Hancock Saskatoon, SK, Canada
To email, remove "nospam" fr
needed for
proper resume handling, this also removes the inline helper functions
for getting ADMA register locations by storing the pointers so we don't
have to keep calculating them all the time.
Signed-off-by: Robert Hancock <[EMAIL PROTECTED]>
---
Robert Hancock Saskat
: Robert Hancock <[EMAIL PROTECTED]>
--
Robert Hancock Saskatoon, SK, Canada
To email, remove "nospam" from [EMAIL PROTECTED]
Home Page: http://www.roberthancock.com/
--- linux-2.6.19-rc6-mm1/drivers/ata/sata_nv.c 2006-11-25 10:04:14.0
-0600
+++ linux-2.6.19-rc6-mm1-adm
101 - 190 of 190 matches
Mail list logo
