> Could you try the patch below and give me all boot messages again?
Sure, no problem, see below for full log (I updated to the latest git,
which seems to have some other unrelated problems with things timing
out earlier in the boot, but it does get to the ide-cd init); here's
the relevant lookin
here you go!
http://bugzilla.kernel.org/show_bug.cgi?id=9687
- Original Message -
From: "Alan Cox" <[EMAIL PROTECTED]>
To: <[EMAIL PROTECTED]>
Cc: ; <[EMAIL PROTECTED]>
Sent: Friday, January 04, 2008 4:49 PM
Subject: Re: pata_winbond doesn`t unregister from sysfs - bug?
On Fri, 04 J
> Hey, I appreciate it, but I really do have to warn you that I did this all
> blind, and just meant for it to be a "I think this kind of direction is
> more productive" thing. I'm not going to guarantee that it works at all.
Oh, understood, and I'm definitely planning on taking your patch as
real structure pointer
> instead of just a "void *", maybe I left some pointer arithmetic around
> that expected it to work as a byte pointer, but now really works on the
> whole structure size instead).
Given that you took the time to do this, I'll get the patch into a
wo
> > So setting a variable to something meaningless (guaranteeing that a
> > garbage value is used in case of a bug) just to shut up a warning makes
> > no sense -- it's no safer than leaving the code as is.
>
> Wrong.
>
> It's safer for two reasons:
> - now everybody will see the *sa
I think this patch (on top of the previous one) actually makes the
code clearer, and also makes it smaller:
add/remove: 0/0 grow/shrink: 0/3 up/down: 0/-41 (-41)
function old new delta
mthca_tavor_post_send 13441335 -9
mthca_
en. I think
things could be cleaned up and made more efficient by getting rid of
the initialization of size0 too -- I'll look at doing that)
Anyway, I queued this up for my next merge with Linus:
commit 6d7d080e9f7cd535a8821efd3835c5cfa5223ab6
Author: Roland Dreier <[EMAIL PROTECTE
> drivers/infiniband/hw/mthca/mthca_qp: kill uninit'd var warning
>
> drivers/infiniband/hw/mthca/mthca_qp.c: In function
> âmthca_tavor_post_sendâ:
> drivers/infiniband/hw/mthca/mthca_qp.c:1594: warning: âf0â may be
> used
> uninitialized in this functi
Jeff> Look at net drivers. Theres no real infrastructure beyond
Jeff> bit tests and printks. I wouldn't call that a subsystem,
Jeff> so, I wouldn't call this one such either.
Well, scsi_logging.h isn't much of a subsystem either.
- R.
-
To unsubscribe from this list: send the line
Jeff> In any case, I also contine to be skeptical of in-kernel
Jeff> logging subsystems.
Aren't you proposing a libata logging subsystem?
- R.
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http
Hi all,
Together with a couple of others I have been bitten by problems with the
Promise SATAII TX4 controller.
Common to all is that at some point the kernel log contains the "irq
: nobody cared!" error message, followed by a call/stack
trace. This is quickly followed up by a "Disabling IRQ #"
w
ferencing a cast and as
such is totally correct, idiomatic and clean C.
- Roland
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
12 matches
Mail list logo
