Re: [PATCH] Correctly prevent IDE timer expiry function to run if request was already handled

2007-04-06 Thread Suleiman Souhlal
On Fri, April 6, 2007 12:22 pm, Sergei Shtylyov wrote: Hello. Suleiman Souhlal wrote: It is possible for the timer expiry function to run even though the request has already been handled: ide_timer_expiry() only checks that the handler is not NULL, but it is possible that we have handled

Re: [PATCH 3/3] Use correct IDE error recovery

2007-03-08 Thread Suleiman Souhlal
On Mar 7, 2007, at 1:16 PM, Bartlomiej Zolnierkiewicz wrote: Hi, (sorry for the long delay) On Wednesday 21 February 2007, Suleiman Souhlal wrote: IDE error recovery is using WIN_IDLEIMMEDIATE which was only valid for IDE V1 and IDE V2. Modern drives will not be able to recover using

Re: [PATCH 3/3] Use correct IDE error recovery

2007-03-08 Thread Suleiman Souhlal
On Mar 8, 2007, at 12:34 PM, Bartlomiej Zolnierkiewicz wrote: Hi, On Thursday 08 March 2007, Suleiman Souhlal wrote: On Mar 7, 2007, at 1:16 PM, Bartlomiej Zolnierkiewicz wrote: Hi, (sorry for the long delay) On Wednesday 21 February 2007, Suleiman Souhlal wrote: IDE error recovery

[PATCH 1/3] Make the IDE DMA timeout modifiable

2007-02-20 Thread Suleiman Souhlal
It can be changed via /proc/ide/hd?/settings. Signed-off-by: Ed Falk [EMAIL PROTECTED] --- drivers/ide/ide-dma.c |3 ++- drivers/ide/ide.c |2 ++ include/linux/ide.h |3 +++ 3 files changed, 7 insertions(+), 1 deletions(-) diff --git a/drivers/ide/ide-dma.c

[PATCH 3/3] Use correct IDE error recovery

2007-02-20 Thread Suleiman Souhlal
IDE error recovery is using WIN_IDLEIMMEDIATE which was only valid for IDE V1 and IDE V2. Modern drives will not be able to recover using this error handling. The correct thing to do is issue a SRST followed by a SET_FEATURES. Signed-off-by: Suleiman Souhlal [EMAIL PROTECTED] --- drivers/ide

[PATCH 2/3] Don't change transfer speed while requests are in flight

2007-02-20 Thread Suleiman Souhlal
there, remove some commented-out code. Signed-off-by: Suleiman Souhlal [EMAIL PROTECTED] --- drivers/ide/ide-iops.c | 35 --- 1 files changed, 20 insertions(+), 15 deletions(-) diff --git a/drivers/ide/ide-iops.c b/drivers/ide/ide-iops.c index c67b3b1..35ab3af

Re: [PATCH 1/3] Make the IDE DMA timeout modifiable

2007-02-20 Thread Suleiman Souhlal
On Feb 20, 2007, at 5:44 PM, Bartlomiej Zolnierkiewicz wrote: On Wednesday 21 February 2007 02:19, Suleiman Souhlal wrote: It can be changed via /proc/ide/hd?/settings. Why do we need to change IDE DMA timeout dynamically? I've used it to test error recovery (for example). BTW /proc