Re: [IDE] Fix build bug

2007-11-02 Thread Ralf Baechle
On Thu, Nov 01, 2007 at 06:43:16PM +, Denys Vlasenko wrote: We can intrduce new, ro sections or teach gcc that combining const objects into non-ro sections is not a crime. I wonder why it currently disallows that. (And it does it only _somethimes_, const pointers happily go into rw

Re: [IDE] Fix build bug

2007-11-01 Thread Denys Vlasenko
On Tuesday 30 October 2007 12:41, Ralf Baechle wrote: On Tue, Oct 30, 2007 at 11:34:29AM +, Denys Vlasenko wrote: On Thursday 25 October 2007 22:41, Bartlomiej Zolnierkiewicz wrote: -static const struct ide_port_info generic_chipsets[] __devinitdata = { +static struct

Re: [IDE] Fix build bug

2007-10-30 Thread Denys Vlasenko
On Thursday 25 October 2007 22:41, Bartlomiej Zolnierkiewicz wrote: -static const struct ide_port_info generic_chipsets[] __devinitdata = { +static struct ide_port_info generic_chipsets[] __devinitdata = { /* 0 */ DECLARE_GENERIC_PCI_DEV(Unknown, 0), { /* 1 */ I

Re: [IDE] Fix build bug

2007-10-30 Thread Ralf Baechle
On Tue, Oct 30, 2007 at 11:34:29AM +, Denys Vlasenko wrote: On Thursday 25 October 2007 22:41, Bartlomiej Zolnierkiewicz wrote: -static const struct ide_port_info generic_chipsets[] __devinitdata = { +static struct ide_port_info generic_chipsets[] __devinitdata = { /* 0 */

Re: [IDE] Fix build bug

2007-10-30 Thread Bartlomiej Zolnierkiewicz
On Tuesday 30 October 2007, Ralf Baechle wrote: On Tue, Oct 30, 2007 at 11:34:29AM +, Denys Vlasenko wrote: On Thursday 25 October 2007 22:41, Bartlomiej Zolnierkiewicz wrote: -static const struct ide_port_info generic_chipsets[] __devinitdata = { +static struct ide_port_info

[IDE] Fix build bug

2007-10-25 Thread Ralf Baechle
CC drivers/ide/pci/generic.o drivers/ide/pci/generic.c:52: error: __setup_str_ide_generic_all_on causes a +section type conflict This sort of build error is becoming a regular issue. Either all or non of the elements that go into a particular section of a compilation unit need to be