Re: [PATCH] Unbreak build of PMP with ACPI disabled

2007-07-16 Thread Tejun Heo
[cc'ing Jeff and Albert] Petr Vandrovec wrote: > Fix reported task file values in sense data > > ata_tf_read was setting HOB bit when lba48 command was submitted, but > was not clearing it before reading "normal" data. Maybe it would be > better to just clear HOB bit immediately after reading up

Re: [PATCH] Unbreak build of PMP with ACPI disabled

2007-07-15 Thread Ryan Power
At 06:13 AM 7/14/2007, Petr Vandrovec wrote: Tejun Heo wrote: Ryan Power wrote: I'm also experiencing this problem on a with the sata_nv module. I suspect that it may at least not be controller dependant, as it's also occurring on my silicon image controller (sata_sil, SiI3512). It looks like

Re: [PATCH] Unbreak build of PMP with ACPI disabled

2007-07-14 Thread Petr Vandrovec
Tejun Heo wrote: Ryan Power wrote: I'm also experiencing this problem on a with the sata_nv module. I suspect that it may at least not be controller dependant, as it's also occurring on my silicon image controller (sata_sil, SiI3512). It looks like something is zeroing out part of the return r

Re: [PATCH] Unbreak build of PMP with ACPI disabled

2007-07-13 Thread Tejun Heo
Ryan Power wrote: > I'm also experiencing this problem on a with the sata_nv module. I > suspect that it may at least not be controller dependant, as it's also > occurring on my silicon image controller (sata_sil, SiI3512). It looks > like something is zeroing out part of the return registers for

Re: [PATCH] Unbreak build of PMP with ACPI disabled

2007-07-13 Thread Ryan Power
I'm also experiencing this problem on a with the sata_nv module. I suspect that it may at least not be controller dependant, as it's also occurring on my silicon image controller (sata_sil, SiI3512). It looks like something is zeroing out part of the return registers for the overall smart stat

Re: [PATCH] Unbreak build of PMP with ACPI disabled

2007-07-13 Thread Robert Hancock
Tejun Heo wrote: Only problem I've noticed is that smartctl on drives connected to sata_nv needs '-T permissive', while if same drive is connected to sata_sil24's PMP, it works without problem. Error SMART Status command failed Please get assistance from http://smartmontools.sourceforge.net/

[PATCH] Unbreak build of PMP with ACPI disabled

2007-07-13 Thread Petr Vandrovec
Hello, first let me thank you for your PMP code. Works great. Though I could not built it with ACPI disable - it is possible that I did merge wrong (I'm using your tree with current Linus's TOT), though I do not think. Patch is at the end. If you are interested in success report, then my dmes

Re: [PATCH] Unbreak build of PMP with ACPI disabled

2007-07-13 Thread Tejun Heo
Petr Vandrovec wrote: > Hello, > first let me thank you for your PMP code. Works great. Though I could not > built it with ACPI disable - it is possible that I did merge wrong (I'm using > your tree with current Linus's TOT), though I do not think. Patch is at > the end. It's my screw up. I