Re: [PATCH] ahci: enable GHC.AE bit before set GHC.HR

2007-09-26 Thread Jeff Garzik
Alan Cox wrote: On Wed, 26 Sep 2007 10:33:28 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: Alan Cox wrote: NAK - mmio is an iomap so writel and readl are the wrong things to use The patch is consistent with the rest of the driver. You are welcome to submit a patch to convert ahci to using iore

Re: [PATCH] ahci: enable GHC.AE bit before set GHC.HR

2007-09-26 Thread Alan Cox
On Wed, 26 Sep 2007 10:33:28 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > Alan Cox wrote: > >>> NAK - mmio is an iomap so writel and readl are the wrong things to use > >> The patch is consistent with the rest of the driver. > >> You are welcome to submit a patch to convert ahci to using ioremap

Re: [PATCH] ahci: enable GHC.AE bit before set GHC.HR

2007-09-26 Thread Jeff Garzik
Alan Cox wrote: NAK - mmio is an iomap so writel and readl are the wrong things to use The patch is consistent with the rest of the driver. You are welcome to submit a patch to convert ahci to using ioremap. You could just flip the relevant function to use ioread while you are tidying it up, i

Re: [PATCH] ahci: enable GHC.AE bit before set GHC.HR

2007-09-26 Thread Alan Cox
> > NAK - mmio is an iomap so writel and readl are the wrong things to use > > The patch is consistent with the rest of the driver. > You are welcome to submit a patch to convert ahci to using ioremap. You could just flip the relevant function to use ioread while you are tidying it up, instead of

Re: [PATCH] ahci: enable GHC.AE bit before set GHC.HR

2007-09-26 Thread Jeff Garzik
Alan Cox wrote: On Wed, 26 Sep 2007 00:03:19 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: Peer Chen wrote: According to the description of section 5.2.2.1 and 10.1.2 of AHCI specification rev1_1/rev1_2, GHC.HR shall only be set to ¡®1¡¯ by software when GHC.AE is set to ¡®1¡¯. Signed-off-by:

Re: [PATCH] ahci: enable GHC.AE bit before set GHC.HR

2007-09-26 Thread Alan Cox
On Wed, 26 Sep 2007 00:03:19 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > Peer Chen wrote: > > According to the description of section 5.2.2.1 and 10.1.2 of AHCI > > specification rev1_1/rev1_2, GHC.HR shall only be set to ¡®1¡¯ > > by software when GHC.AE is set to ¡®1¡¯. > > > > Signed-off-b

Re: [PATCH] ahci: enable GHC.AE bit before set GHC.HR

2007-09-25 Thread Jeff Garzik
Peer Chen wrote: According to the description of section 5.2.2.1 and 10.1.2 of AHCI specification rev1_1/rev1_2, GHC.HR shall only be set to ¡®1¡¯ by software when GHC.AE is set to ¡®1¡¯. Signed-off-by: Peer Chen <[EMAIL PROTECTED]> --- --- linux-2.6.23-rc7/drivers/ata/ahci.c.orig2007-09-20

Re: [PATCH] ahci: enable GHC.AE bit before set GHC.HR

2007-09-21 Thread Jens Axboe
On Fri, Sep 21 2007, Alan Cox wrote: > On Fri, 21 Sep 2007 12:31:20 +0200 > Jens Axboe <[EMAIL PROTECTED]> wrote: > > > On Fri, Sep 21 2007, Peer Chen wrote: > > > According to the description of section 5.2.2.1 and 10.1.2 of AHCI > > > specification rev1_1/rev1_2, GHC.HR shall only be set to ¡®1

Re: [PATCH] ahci: enable GHC.AE bit before set GHC.HR

2007-09-21 Thread Alan Cox
On Fri, 21 Sep 2007 12:31:20 +0200 Jens Axboe <[EMAIL PROTECTED]> wrote: > On Fri, Sep 21 2007, Peer Chen wrote: > > According to the description of section 5.2.2.1 and 10.1.2 of AHCI > > specification rev1_1/rev1_2, GHC.HR shall only be set to ¡®1¡¯ > > by software when GHC.AE is set to ¡®1¡¯. >

Re: [PATCH] ahci: enable GHC.AE bit before set GHC.HR

2007-09-21 Thread Jens Axboe
On Fri, Sep 21 2007, Peer Chen wrote: > According to the description of section 5.2.2.1 and 10.1.2 of AHCI > specification rev1_1/rev1_2, GHC.HR shall only be set to ¡®1¡¯ > by software when GHC.AE is set to ¡®1¡¯. > > Signed-off-by: Peer Chen <[EMAIL PROTECTED]> > --- > --- linux-2.6.23-rc7/driv

Re: [PATCH] ahci: enable GHC.AE bit before set GHC.HR

2007-09-21 Thread Andrew Morton
On Fri, 21 Sep 2007 13:28:01 +0800 "Peer Chen" <[EMAIL PROTECTED]> wrote: > According to the description of section 5.2.2.1 and 10.1.2 of AHCI > specification rev1_1/rev1_2, GHC.HR shall only be set to __1__ > by software when GHC.AE is set to __1__. This text contained non-ascii garbage which c

[PATCH] ahci: enable GHC.AE bit before set GHC.HR

2007-09-20 Thread Peer Chen
According to the description of section 5.2.2.1 and 10.1.2 of AHCI specification rev1_1/rev1_2, GHC.HR shall only be set to ¡®1¡¯ by software when GHC.AE is set to ¡®1¡¯. Signed-off-by: Peer Chen <[EMAIL PROTECTED]> --- --- linux-2.6.23-rc7/drivers/ata/ahci.c.orig2007-09-20 11:01:55.0