Re: Disabling ADMA? (was Re: [PATCH] drivers/ata: Add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61)

2007-07-07 Thread Robert Hancock
Jeff Garzik wrote: Kuan Luo wrote: @@ -1714,3 +2761,6 @@ module_init(nv_init); module_exit(nv_exit); module_param_named(adma, adma_enabled, bool, 0444); MODULE_PARM_DESC(adma, Enable use of ADMA (Default: true)); +module_param_named(ncq, ncq_enabled, bool, 0444);

RE: [PATCH] drivers/ata: Add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-05-18 Thread Kuan Luo
Thanks for your comment, see the explaination inline. We'll apply your advice in later patch. -Original Message- From: Robert Hancock [mailto:[EMAIL PROTECTED] Sent: Friday, May 18, 2007 9:48 AM To: Peer Chen Cc: [EMAIL PROTECTED]; Jeff Garzik; [EMAIL PROTECTED]; Kuan Luo;

Re: [PATCH] drivers/ata: Add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-05-18 Thread Robert Hancock
Kuan Luo wrote: Thanks for your comment, see the explaination inline. We'll apply your advice in later patch. ... Please don't duplicate this code in the driver, this is part of libata core in libata-scsi.c. Add an export for these functions if you need to use them in the driver. [kuan]:

Re: [PATCH] drivers/ata: Add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-05-17 Thread Robert Hancock
Peer Chen wrote: Add the Software NCQ support to sata_nv.c for MCP51/MCP55/MCP61 SATA controller. This patch base on sata_nv.c file from kernel 2.6.22-rc1 See attachment for the patch. Signed-off-by: Kuan Luo [EMAIL PROTECTED] Signed-off-by: Peer Chen [EMAIL PROTECTED] Good to finally see