Re: [PATCH] drivers/firmware: const-ify DMI API and internals

2007-09-11 Thread Bartlomiej Zolnierkiewicz
On Saturday 01 September 2007, Jeff Garzik wrote: commit 457b6eb3bf3341d2e143518a0bb99ffbb8d754c4 Author: Jeff Garzik [EMAIL PROTECTED] Date: Sat Sep 1 10:16:45 2007 -0400 drivers/firmware: const-ify DMI API and internals Three main sets of changes: 1)

Re: [PATCH] drivers/firmware: const-ify DMI API and internals

2007-09-09 Thread Greg KH
On Sat, Sep 01, 2007 at 12:01:20PM -0400, Jeff Garzik wrote: Greg KH wrote: On Sat, Sep 01, 2007 at 10:27:19AM -0400, Jeff Garzik wrote: commit 457b6eb3bf3341d2e143518a0bb99ffbb8d754c4 Author: Jeff Garzik [EMAIL PROTECTED] Date: Sat Sep 1 10:16:45 2007 -0400 drivers/firmware:

Re: [PATCH] drivers/firmware: const-ify DMI API and internals

2007-09-09 Thread Sam Ravnborg
I was just going to push it myself, but have no strong feelings on the matter. Ok, you can push it, that's fine with me. Feel free to add my: Signed-off-by: Greg Kroah-Hartman [EMAIL PROTECTED] if you want. That should be Acked-by: since the patch does not pass via you but you

Re: [PATCH] drivers/firmware: const-ify DMI API and internals

2007-09-09 Thread Greg KH
On Sun, Sep 09, 2007 at 10:24:42PM +0200, Sam Ravnborg wrote: I was just going to push it myself, but have no strong feelings on the matter. Ok, you can push it, that's fine with me. Feel free to add my: Signed-off-by: Greg Kroah-Hartman [EMAIL PROTECTED] if you want.

Re: [lm-sensors] [PATCH] drivers/firmware: const-ify DMI API and internals

2007-09-02 Thread Jean Delvare
On Sat, 1 Sep 2007 10:27:19 -0400, Jeff Garzik wrote: commit 457b6eb3bf3341d2e143518a0bb99ffbb8d754c4 Author: Jeff Garzik [EMAIL PROTECTED] Date: Sat Sep 1 10:16:45 2007 -0400 drivers/firmware: const-ify DMI API and internals Three main sets of changes: 1)

[PATCH] drivers/firmware: const-ify DMI API and internals

2007-09-01 Thread Jeff Garzik
commit 457b6eb3bf3341d2e143518a0bb99ffbb8d754c4 Author: Jeff Garzik [EMAIL PROTECTED] Date: Sat Sep 1 10:16:45 2007 -0400 drivers/firmware: const-ify DMI API and internals Three main sets of changes: 1) dmi_get_system_info() return value should have been marked const,

Re: [PATCH] drivers/firmware: const-ify DMI API and internals

2007-09-01 Thread Greg KH
On Sat, Sep 01, 2007 at 10:27:19AM -0400, Jeff Garzik wrote: commit 457b6eb3bf3341d2e143518a0bb99ffbb8d754c4 Author: Jeff Garzik [EMAIL PROTECTED] Date: Sat Sep 1 10:16:45 2007 -0400 drivers/firmware: const-ify DMI API and internals Three main sets of changes:

Re: [PATCH] drivers/firmware: const-ify DMI API and internals

2007-09-01 Thread Jeff Garzik
Greg KH wrote: On Sat, Sep 01, 2007 at 10:27:19AM -0400, Jeff Garzik wrote: commit 457b6eb3bf3341d2e143518a0bb99ffbb8d754c4 Author: Jeff Garzik [EMAIL PROTECTED] Date: Sat Sep 1 10:16:45 2007 -0400 drivers/firmware: const-ify DMI API and internals Three main sets of changes:

Re: [PATCH] drivers/firmware: const-ify DMI API and internals

2007-09-01 Thread Andi Kleen
And if we're really lucky, this might enable some additional optimizations on the part of the compiler. Only if the kernel was compiled C++. C compilers generally ignore constness for optimization purposes because it can be so easily casted away. -Andi - To unsubscribe from this list:

Re: [PATCH] drivers/firmware: const-ify DMI API and internals

2007-09-01 Thread Satyam Sharma
On Sat, 1 Sep 2007, Andi Kleen wrote: And if we're really lucky, this might enable some additional optimizations on the part of the compiler. Only if the kernel was compiled C++. C compilers generally ignore constness for optimization purposes because it can be so easily casted