Re: [PATCH] libata: implement and use DMA mask configuration helper

2007-04-09 Thread Tejun Heo
Jeff Garzik wrote: > Tejun Heo wrote: >> Jeff, there are further problems with doing pci_go_64() only on devices >> which support 64bit. pci_set_dma_mask() is the only place where the PCI >> code can test whether DMA is usable or not, so if we don't configure DMA >> mask on 32bit controllers, ther

Re: [PATCH] libata: implement and use DMA mask configuration helper

2007-04-09 Thread Jeff Garzik
Tejun Heo wrote: Jeff, there are further problems with doing pci_go_64() only on devices which support 64bit. pci_set_dma_mask() is the only place where the PCI code can test whether DMA is usable or not, so if we don't configure DMA mask on 32bit controllers, there's no way to tell whether DMA

Re: [PATCH] libata: implement and use DMA mask configuration helper

2007-04-09 Thread Tejun Heo
Jeff Garzik wrote: > Tejun Heo wrote: >> Jeff Garzik wrote: >>> Tejun Heo wrote: Implement and use DMA mask configuration helper. Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> --- This function probably belongs to pci layer. Put it in libata with pci_test_bits() for th

Re: [PATCH] libata: implement and use DMA mask configuration helper

2007-03-18 Thread Tejun Heo
Jeff Garzik wrote: > Tejun Heo wrote: >> Jeff Garzik wrote: >>> Tejun Heo wrote: Implement and use DMA mask configuration helper. Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> --- This function probably belongs to pci layer. Put it in libata with pci_test_bits() for th

Re: [PATCH] libata: implement and use DMA mask configuration helper

2007-03-18 Thread Jeff Garzik
Tejun Heo wrote: Jeff Garzik wrote: Tejun Heo wrote: Implement and use DMA mask configuration helper. Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> --- This function probably belongs to pci layer. Put it in libata with pci_test_bits() for the time being. AFAIK the default DMA mask is always 3

Re: [PATCH] libata: implement and use DMA mask configuration helper

2007-03-18 Thread Tejun Heo
Jeff Garzik wrote: > Tejun Heo wrote: >> Implement and use DMA mask configuration helper. >> >> Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> >> --- >> This function probably belongs to pci layer. Put it in libata with >> pci_test_bits() for the time being. > > AFAIK the default DMA mask is always

Re: [PATCH] libata: implement and use DMA mask configuration helper

2007-03-09 Thread Tejun Heo
Jeff Garzik wrote: > Tejun Heo wrote: >> Implement and use DMA mask configuration helper. >> >> Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> >> --- >> This function probably belongs to pci layer. Put it in libata with >> pci_test_bits() for the time being. > > AFAIK the default DMA mask is always

Re: [PATCH] libata: implement and use DMA mask configuration helper

2007-03-09 Thread Jeff Garzik
Tejun Heo wrote: Implement and use DMA mask configuration helper. Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> --- This function probably belongs to pci layer. Put it in libata with pci_test_bits() for the time being. AFAIK the default DMA mask is always 32-bit. Code (often written by me) t

Re: [PATCH] libata: implement and use DMA mask configuration helper

2007-03-09 Thread Alan Cox
On Fri, 9 Mar 2007 19:49:45 +0900 Tejun Heo <[EMAIL PROTECTED]> wrote: > Implement and use DMA mask configuration helper. > > Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> Acked-by: Alan Cox <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of

[PATCH] libata: implement and use DMA mask configuration helper

2007-03-09 Thread Tejun Heo
Implement and use DMA mask configuration helper. Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> --- This function probably belongs to pci layer. Put it in libata with pci_test_bits() for the time being. drivers/ata/ahci.c | 36 + drivers/ata/libata-core.c | 70 +