[PATCH] libata: skip FLUSH and STADNBYNOW1 during shutdown if device is already spun down

2007-04-23 Thread Tejun Heo
libata didn't use to spin down disks properly on shutdown and userland shutdown(8) worked around it by synchronizing cache and spinning down by itself before telling the kernel to shutdown. However, this userland work around collides with libata shutdown because some drives spin up if it receives

Re: [PATCH] libata: skip FLUSH and STADNBYNOW1 during shutdown if device is already spun down

2007-04-23 Thread Robert Hancock
Tejun Heo wrote: libata didn't use to spin down disks properly on shutdown and userland shutdown(8) worked around it by synchronizing cache and spinning down by itself before telling the kernel to shutdown. However, this userland work around collides with libata shutdown because some drives

Re: [PATCH] libata: skip FLUSH and STADNBYNOW1 during shutdown if device is already spun down

2007-04-23 Thread Tejun Heo
Robert Hancock wrote: This patch makes libata skip FLUSH and STANDBYNOW1 during shutdown if the drive is already spun down. Note that whether FLUSH has been performed is not checked. This is because some userland shutdown(8)'s only do STANDBYNOW1. Transition to standby mode implies cache