Re: [PATCH] libata-core: Don't have screaming fits over DF/ERR combinations

2007-10-24 Thread Jeff Garzik
Alan Cox wrote: Some hardware seems to get this wrong in a non-harmful way, and there are some devices that seem to do it deliberately for various reasons. Just take it as a device error not a catastrophic state machine explosion. Signed-off-by: Alan Cox <[EMAIL PROTECTED]> applied to #for-

Re: [PATCH] libata-core: Don't have screaming fits over DF/ERR combinations

2007-10-15 Thread Alan Cox
> Yes, hence the recent FIFO drain patches. > > But that doesn't make sense for SATA devices, where the FIFO is really > emulated, and it works on older PATA devices. The FIFO is emulated on PATA. Basically speaking the device prefetches data and buffers the irq arrival until the right moment. H

Re: [PATCH] libata-core: Don't have screaming fits over DF/ERR combinations

2007-10-15 Thread Jeff Garzik
Sergei Shtylyov wrote: Jeff Garzik wrote: Some hardware seems to get this wrong in a non-harmful way, and there are some devices that seem to do it deliberately for various reasons. Just take it as a device error not a catastrophic state machine explosion. Signed-off-by: Alan Cox <[EMAI

Re: [PATCH] libata-core: Don't have screaming fits over DF/ERR combinations

2007-10-15 Thread Sergei Shtylyov
Jeff Garzik wrote: Some hardware seems to get this wrong in a non-harmful way, and there are some devices that seem to do it deliberately for various reasons. Just take it as a device error not a catastrophic state machine explosion. Signed-off-by: Alan Cox <[EMAIL PROTECTED]> diff -u

Re: [PATCH] libata-core: Don't have screaming fits over DF/ERR combinations

2007-10-15 Thread Jeff Garzik
Sergei Shtylyov wrote: Alan Cox wrote: Some hardware seems to get this wrong in a non-harmful way, and there are some devices that seem to do it deliberately for various reasons. Just take it as a device error not a catastrophic state machine explosion. Signed-off-by: Alan Cox <[EMAIL PR

Re: [PATCH] libata-core: Don't have screaming fits over DF/ERR combinations

2007-10-15 Thread Sergei Shtylyov
Alan Cox wrote: Some hardware seems to get this wrong in a non-harmful way, and there are some devices that seem to do it deliberately for various reasons. Just take it as a device error not a catastrophic state machine explosion. Signed-off-by: Alan Cox <[EMAIL PROTECTED]> diff -u --exc

[PATCH] libata-core: Don't have screaming fits over DF/ERR combinations

2007-10-15 Thread Alan Cox
Some hardware seems to get this wrong in a non-harmful way, and there are some devices that seem to do it deliberately for various reasons. Just take it as a device error not a catastrophic state machine explosion. Signed-off-by: Alan Cox <[EMAIL PROTECTED]> diff -u --exclude-from /usr/src/excl