[PATCH] libata-sff: Correct use of check_status()

2007-10-15 Thread Alan Cox
ata_check_status() does an SFF compliant check ata_chk_status() does a generic call to ap->ops->check_status (usually ata_check_status) libata-sff uses the wrong one. Hardly suprising given the naming here, which ought to get fixed to ata_sff_check_status() perhaps ? Signed-off-by: Alan Cox <[EMA

Re: [PATCH] libata-sff: Correct use of check_status()

2007-10-17 Thread Jeff Garzik
Alan Cox wrote: ata_check_status() does an SFF compliant check ata_chk_status() does a generic call to ap->ops->check_status (usually ata_check_status) libata-sff uses the wrong one. Hardly suprising given the naming here, which ought to get fixed to ata_sff_check_status() perhaps ? Signed-off-

Re: [PATCH] libata-sff: Correct use of check_status()

2007-10-22 Thread Alan Cox
> > + tf->command = ata_chk_status(ap); > > tf->feature = ioread8(ioaddr->error_addr); > > tf->nsect = ioread8(ioaddr->nsect_addr); > > tf->lbal = ioread8(ioaddr->lbal_addr); > > applied, with a sigh: it's in SFF, so I saw nothing wrong with > ata_check_status(). I checked -- no S

Re: [PATCH] libata-sff: Correct use of check_status()

2007-10-22 Thread Jeff Garzik
Alan Cox wrote: + tf->command = ata_chk_status(ap); tf->feature = ioread8(ioaddr->error_addr); tf->nsect = ioread8(ioaddr->nsect_addr); tf->lbal = ioread8(ioaddr->lbal_addr); applied, with a sigh: it's in SFF, so I saw nothing wrong with ata_check_status(). I chec