Re: [PATCH] libata drain fifo on stuck DRQ HSM violation

2007-09-29 Thread Mark Lord
Alan Cox wrote: Why 512 words ? Though I have queued Mark's patch to be applied, my gut feeling would lean towards a single DRQ block, rather than 512. Why not just work from the old IDE code. ata_altstatus(ap); - ata_chk_status(ap); + ata_drain_fifo(ap, qc); ap->ops->c

Re: [PATCH] libata drain fifo on stuck DRQ HSM violation (try#2)

2007-09-28 Thread Jeff Garzik
Mark Lord wrote: I think this original patch still applies cleanly on at least 2.6.23-rc7. Drain up to 512 words from host/bridge FIFO on stuck DRQ HSM violation, rather than just getting stuck there forever. Signed-off-by: Mark Lord <[EMAIL PROTECTED]> --- --- old/drivers/ata/libata-sff.c

Re: [PATCH] libata drain fifo on stuck DRQ HSM violation

2007-09-28 Thread Alan Cox
> > Why 512 words ? > > Though I have queued Mark's patch to be applied, my gut feeling would > lean towards a single DRQ block, rather than 512. Why not just work from the old IDE code. > > > >>ata_altstatus(ap); > >> - ata_chk_status(ap); > >> + ata_drain_fifo(ap, qc); > > > > ap->ops

Re: [PATCH] libata drain fifo on stuck DRQ HSM violation

2007-09-28 Thread Jeff Garzik
Alan Cox wrote: Drain up to 512 words from host/bridge FIFO on stuck DRQ HSM violation, rather than just getting stuck there forever. Why 512 words ? Though I have queued Mark's patch to be applied, my gut feeling would lean towards a single DRQ block, rather than 512. ata_altsta

[PATCH] libata drain fifo on stuck DRQ HSM violation (try#2)

2007-09-28 Thread Mark Lord
Alan Cox wrote: Drain up to 512 words from host/bridge FIFO on stuck DRQ HSM violation, rather than just getting stuck there forever. Why 512 words ? ata_altstatus(ap); - ata_chk_status(ap); + ata_drain_fifo(ap, qc); ap->ops->cleanup(); might be wiser Actually, I bel

Re: [PATCH] libata drain fifo on stuck DRQ HSM violation

2007-09-28 Thread Alan Cox
> Drain up to 512 words from host/bridge FIFO on stuck DRQ HSM violation, > rather than just getting stuck there forever. Why 512 words ? > ata_altstatus(ap); > - ata_chk_status(ap); > + ata_drain_fifo(ap, qc); ap->ops->cleanup(); might be wiser - To unsubscribe from this list: s

Re: [PATCH] libata drain fifo on stuck DRQ HSM violation

2007-09-28 Thread Tejun Heo
> Nacked-by: scripts/checkpatch.pl Mark, it seems you'll have to get ACK from this dude first. :-) -- tejun - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] libata drain fifo on stuck DRQ HSM violation

2007-09-28 Thread Andrew Morton
On Fri, 28 Sep 2007 02:48:28 -0700 Tejun Heo <[EMAIL PROTECTED]> wrote: > Mark Lord wrote: > > Drain up to 512 words from host/bridge FIFO on stuck DRQ HSM violation, > > rather than just getting stuck there forever. > > > > Signed-Off-By: Mark Lord <[EMAIL PROTECTED]> > > Acked-by: Tejun Heo <

Re: [PATCH] libata drain fifo on stuck DRQ HSM violation

2007-09-28 Thread Tejun Heo
Mark Lord wrote: > Drain up to 512 words from host/bridge FIFO on stuck DRQ HSM violation, > rather than just getting stuck there forever. > > Signed-Off-By: Mark Lord <[EMAIL PROTECTED]> Acked-by: Tejun Heo <[EMAIL PROTECTED]> -- tejun - To unsubscribe from this list: send the line "unsubscri

[PATCH] libata drain fifo on stuck DRQ HSM violation

2007-09-27 Thread Mark Lord
Tejun Heo wrote: Jeff Garzik wrote: Tejun Heo wrote: Alan Cox wrote: I think there have been enough cases where this draining was necessary. IIRC, ata_piix was involved in those cases, right? If so, can you please submit a patch which applies this only to affected controllers? I don't feel t