Re: [PATCH] pasemi: electra IDE/pata_platform glue

2007-05-13 Thread Olof Johansson
Hi, On Sun, May 13, 2007 at 02:48:22AM +0200, Arnd Bergmann wrote: > Olof, have you looked at which of the two ->set_mode functions is more > appropriate for electra? I would guess that you actually want to use > the ata_generic one. Actually, the pata_platform driver is _exactly_ what I want at

Re: [PATCH] pasemi: electra IDE/pata_platform glue

2007-05-13 Thread Alan Cox
> > Easier to use pata_platform I would think ? Just create the OF device and > > bind it to pata_platform. > > Not sure I understand what you mean. pata_platform expects a platform_device, > which cannot be cast from an of_device. Other than the binding and wanting to use the standard ->set_mode

Re: [PATCH] pasemi: electra IDE/pata_platform glue

2007-05-13 Thread Segher Boessenkool
Also, in this particular case, the bindings are not standardized, and there's a good chance that whatever new platform uses a similar device will need to do something slightly different. Yeah, everyone else will do the sane thing, and describe the two register ranges the IDE uses, not a much big

Re: [PATCH] pasemi: electra IDE/pata_platform glue

2007-05-13 Thread Benjamin Herrenschmidt
> Great. That should fit perfectly with the glue I have now, it'll turn > into the constructor instead. > > I honestly don't see what the benefit is of this recent obsession > with creating of_platform devices for every new device that's not > PCI, especially when there's an already well-fitting

Re: [PATCH] pasemi: electra IDE/pata_platform glue

2007-05-12 Thread Olof Johansson
On Sun, May 13, 2007 at 12:20:10PM +1000, Benjamin Herrenschmidt wrote: > > Then, the plans I have in mind for the future of that stuff are around > the idea of registering "constructors" based on bus matches and device > matches respectively. > > The kernel will then walk the whole OF device-tree

Re: [PATCH] pasemi: electra IDE/pata_platform glue

2007-05-12 Thread Benjamin Herrenschmidt
On Sun, 2007-05-13 at 02:48 +0200, Arnd Bergmann wrote: > On Sunday 13 May 2007, Alan Cox wrote: > > > Why not provide a proper pata_of.c driver based on ata_generic? That > > > will help the next person that has a builtin ata controller and wants > > > to get it running as an of_device. > > > > E

Re: [PATCH] pasemi: electra IDE/pata_platform glue

2007-05-12 Thread Arnd Bergmann
On Sunday 13 May 2007, Alan Cox wrote: > > Why not provide a proper pata_of.c driver based on ata_generic? That > > will help the next person that has a builtin ata controller and wants > > to get it running as an of_device. > > Easier to use pata_platform I would think ? Just create the OF device

Re: [PATCH] pasemi: electra IDE/pata_platform glue

2007-05-12 Thread Alan Cox
> Why not provide a proper pata_of.c driver based on ata_generic? That > will help the next person that has a builtin ata controller and wants > to get it running as an of_device. Easier to use pata_platform I would think ? Just create the OF device and bind it to pata_platform. Alan - To unsubsc

Re: [PATCH] pasemi: electra IDE/pata_platform glue

2007-05-12 Thread Arnd Bergmann
On Saturday 12 May 2007, Olof Johansson wrote: > > We unfortunately need to modify the resources before calling the generic > platform driver, since the device tree only has one register window in > it and the driver expects two. Adding this as an of_platform driver > instead doesn't give us any b

[PATCH] pasemi: electra IDE/pata_platform glue

2007-05-12 Thread Olof Johansson
Glue code to hook up the pata_platform on the PA Semi Electra eval board. CFE sets up device tree entries for the IDE interface, with device type 'ide' and compatible field 'electra-ide'. We unfortunately need to modify the resources before calling the generic platform driver, since the device tre