Re: [PATCH] pata_cmd64x: Correct the speed ranges

2007-08-01 Thread Jeff Garzik
Alan Cox wrote: I must have been half asleep when doing the original code Signed-off-by: Alan Cox <[EMAIL PROTECTED]> applied to #upstream-fixes - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL PROTECTED] More majordomo info at http:/

Re: [PATCH] pata_cmd64x: Correct the speed ranges

2007-07-27 Thread Sergei Shtylyov
Hello. Jeff Garzik wrote: Note that the olde driver has MWDMA fixed, and the new one has it still borken, yet MWDMA2 is the mode you're using. What about MWDMA is broken? The code that "sets" MWDMA timings is completely bogus -- I've already reported that before. And now I've fixed

Re: [PATCH] pata_cmd64x: Correct the speed ranges

2007-07-27 Thread Jeff Garzik
Sergei Shtylyov wrote: Hello. Jeff Garzik wrote: Note that the olde driver has MWDMA fixed, and the new one has it still borken, yet MWDMA2 is the mode you're using. What about MWDMA is broken? The code that "sets" MWDMA timings is completely bogus -- I've already reported that bef

Re: [PATCH] pata_cmd64x: Correct the speed ranges

2007-07-27 Thread Sergei Shtylyov
Hello. Jeff Garzik wrote: Note that the olde driver has MWDMA fixed, and the new one has it still borken, yet MWDMA2 is the mode you're using. What about MWDMA is broken? The code that "sets" MWDMA timings is completely bogus -- I've already reported that before. And now I've fixed

Re: [PATCH] pata_cmd64x: Correct the speed ranges

2007-07-26 Thread Jeff Garzik
Sergei Shtylyov wrote: Note that the olde driver has MWDMA fixed, and the new one has it still borken, yet MWDMA2 is the mode you're using. What about MWDMA is broken? Jeff - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL P

Re: [PATCH] pata_cmd64x: Correct the speed ranges

2007-07-26 Thread Sergei Shtylyov
Mikael Pettersson wrote: This fix inspired me to finally try to convert my Sun Ultra5 (sparc64) with a CMD646 [1095:0646 rev 03] to libata. With pata_cmd64x the machine has so far survived a usual boot/mrproper/reconfig/make/install/reboot kernel update cycle without any issues, and performan

Re: [PATCH] pata_cmd64x: Correct the speed ranges

2007-07-26 Thread Mikael Pettersson
On Thu, 26 Jul 2007 18:43:01 +0100, Alan Cox wrote: > I must have been half asleep when doing the original code > > Signed-off-by: Alan Cox <[EMAIL PROTECTED]> > [patch to fix .udma_mask in pata_cmd64x omitted] This fix inspired me to finally try to convert my Sun Ultra5 (sparc64) with a CMD646

Re: [PATCH] pata_cmd64x: Correct the speed ranges

2007-07-26 Thread Sergei Shtylyov
Hello. Alan Cox wrote: I must have been half asleep when doing the original code Signed-off-by: Alan Cox <[EMAIL PROTECTED]> Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.23rc1-mm1/drivers/ata/pata_cmd64x.c

[PATCH] pata_cmd64x: Correct the speed ranges

2007-07-26 Thread Alan Cox
I must have been half asleep when doing the original code Signed-off-by: Alan Cox <[EMAIL PROTECTED]> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.23rc1-mm1/drivers/ata/pata_cmd64x.c linux-2.6.23rc1-mm1/drivers/ata/pata_cmd64x.c --- linux.vanilla-2.6.23rc1-mm