Re: [PATCH] pata_cmd64x: Set up MWDMA modes properly

2007-08-17 Thread Sergei Shtylyov
Hello. Alan Cox wrote: That function rocks (except I didn't get what the address setup timings mean to SW/MW DMA)... They don't, it merges the DMA and PIO ones and you end up with the PIO ones. What I meant there was this table from libata-core.c: /* * PIO 0-4, MWDMA 0-2 and UDMA

Re: [PATCH] pata_cmd64x: Set up MWDMA modes properly

2007-08-11 Thread Sergei Shtylyov
Hello. Alan Cox wrote: Set the MWDMA timing by updating the correct registers. Split the PIO path as this is mostly shared code. Wants testing. Cool! So much simpler than my fix to the old IDE driver... Signed-off-by: Alan Cox [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL

Re: [PATCH] pata_cmd64x: Set up MWDMA modes properly

2007-08-11 Thread Alan Cox
That function rocks (except I didn't get what the address setup timings mean to SW/MW DMA)... They don't, it merges the DMA and PIO ones and you end up with the PIO ones. + * Used when configuring the devices ot set the PIO timings. All the What's ot? to - will fix regD

Re: [PATCH] pata_cmd64x: Set up MWDMA modes properly

2007-08-11 Thread Bartlomiej Zolnierkiewicz
On Saturday 11 August 2007, Sergei Shtylyov wrote: Hello. Alan Cox wrote: Set the MWDMA timing by updating the correct registers. Split the PIO path as this is mostly shared code. Wants testing. Cool! So much simpler than my fix to the old IDE driver... Signed-off-by: Alan Cox

Re: [PATCH] pata_cmd64x: Set up MWDMA modes properly

2007-08-09 Thread Alan Cox
On Fri, 10 Aug 2007 01:09:13 +0200 (MEST) Mikael Pettersson [EMAIL PROTECTED] wrote: On Wed, 8 Aug 2007 14:33:20 +0100, Alan Cox wrote: Set the MWDMA timing by updating the correct registers. Split the PIO path as this is mostly shared code. Wants testing. Works fine on my CMD646 SPARC

Re: [PATCH] pata_cmd64x: Set up MWDMA modes properly

2007-08-09 Thread Mikael Pettersson
On Wed, 8 Aug 2007 14:33:20 +0100, Alan Cox wrote: Set the MWDMA timing by updating the correct registers. Split the PIO path as this is mostly shared code. Wants testing. Works fine on my CMD646 SPARC Ultra5. /Mikael - To unsubscribe from this list: send the line unsubscribe linux-ide in the

[PATCH] pata_cmd64x: Set up MWDMA modes properly

2007-08-08 Thread Alan Cox
Set the MWDMA timing by updating the correct registers. Split the PIO path as this is mostly shared code. Wants testing. Signed-off-by: Alan Cox [EMAIL PROTECTED] diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.23rc1-mm1/drivers/ata/pata_cmd64x.c