Re: [PATCH] pata_jmicron: fix disabled port handling in jmicron_pre_reset()

2007-11-23 Thread Jeff Garzik
Tejun Heo wrote: There are two bugs in disabled port handling. * test in PORT_PATA0 is reversed * -prereset should return -ENOENT for disabled ports not 0 The first bug makes the PATA channel considered disabled but the second bug saves the day by returning 0. The net result is that cable is

Re: [PATCH] pata_jmicron: fix disabled port handling in jmicron_pre_reset()

2007-11-21 Thread Tejun Heo
Tejun Heo wrote: There are two bugs in disabled port handling. * test in PORT_PATA0 is reversed * -prereset should return -ENOENT for disabled ports not 0 The first bug makes the PATA channel considered disabled but the second bug saves the day by returning 0. The net result is that

[PATCH] pata_jmicron: fix disabled port handling in jmicron_pre_reset()

2007-11-19 Thread Tejun Heo
There are two bugs in disabled port handling. * test in PORT_PATA0 is reversed * -prereset should return -ENOENT for disabled ports not 0 The first bug makes the PATA channel considered disabled but the second bug saves the day by returning 0. The net result is that cable is always left at