Re: [PATCH]libata-acpi: add ACPI _PSx method

2007-11-04 Thread Shaohua Li
On Sat, 2007-11-03 at 09:00 -0400, Jeff Garzik wrote: Shaohua Li wrote: Not sure, this is just to call a BIOS routine, but a check should be safer. Thanks! ACPI spec (ver 3.0a, p289) requires IDE power on/off executes ACPI _PSx methods. As recently most PATA drivers use libata, this

Re: [PATCH]libata-acpi: add ACPI _PSx method

2007-11-04 Thread Shaohua Li
On Fri, 2007-11-02 at 12:16 +0100, Rafael J. Wysocki wrote: Index: linux/drivers/ata/libata-acpi.c === --- linux.orig/drivers/ata/libata-acpi.c2007-11-01 10:54:25.0 +0800 +++ linux/drivers/ata/libata-acpi.c

Re: [PATCH]libata-acpi: add ACPI _PSx method

2007-11-03 Thread Jeff Garzik
Shaohua Li wrote: Not sure, this is just to call a BIOS routine, but a check should be safer. Thanks! ACPI spec (ver 3.0a, p289) requires IDE power on/off executes ACPI _PSx methods. As recently most PATA drivers use libata, this patch adds _PSx method support in libata. ACPI spec doesn't

Re: [PATCH]libata-acpi: add ACPI _PSx method

2007-11-02 Thread Rafael J. Wysocki
On Friday, 2 November 2007 02:32, Shaohua Li wrote: On Thu, 2007-11-01 at 10:04 +, Alan Cox wrote: + max_devices = ata_link_max_devices(ap-link); + + for (i = 0; i max_devices; ++i) { + struct ata_device *dev = ap-link.device[i]; Better to use: ok.

Re: [PATCH]libata-acpi: add ACPI _PSx method

2007-11-01 Thread Alan Cox
+ max_devices = ata_link_max_devices(ap-link); + + for (i = 0; i max_devices; ++i) { + struct ata_device *dev = ap-link.device[i]; Better to use: ata_link_for_each_dev(dev, ap-link) { + + if (dev-acpi_handle) +

Re: [PATCH]libata-acpi: add ACPI _PSx method

2007-11-01 Thread Shaohua Li
On Thu, 2007-11-01 at 10:04 +, Alan Cox wrote: + max_devices = ata_link_max_devices(ap-link); + + for (i = 0; i max_devices; ++i) { + struct ata_device *dev = ap-link.device[i]; Better to use: ok. ata_link_for_each_dev(dev, ap-link) { + +

Re: [PATCH]libata-acpi: add ACPI _PSx method

2007-10-31 Thread Rafael J. Wysocki
On Wednesday, 31 October 2007 03:27, Len Brown wrote: It would be interseting if any of the folks having power consumption problems when suspended see an improvement with this patch. Are there plans to refresh this patch and get it upstream? Acked-by: Len Brown [EMAIL PROTECTED] There was

Re: [PATCH]libata-acpi: add ACPI _PSx method

2007-10-31 Thread Shaohua Li
On Wed, 2007-10-31 at 14:26 +0100, Rafael J. Wysocki wrote: On Wednesday, 31 October 2007 03:27, Len Brown wrote: It would be interseting if any of the folks having power consumption problems when suspended see an improvement with this patch. Are there plans to refresh this patch and get

Re: [PATCH]libata-acpi: add ACPI _PSx method

2007-10-30 Thread Len Brown
It would be interseting if any of the folks having power consumption problems when suspended see an improvement with this patch. Are there plans to refresh this patch and get it upstream? Acked-by: Len Brown [EMAIL PROTECTED] thanks, -Len On Thursday 20 September 2007 22:17, Shaohua Li wrote:

Re: [PATCH]libata-acpi: add ACPI _PSx method

2007-09-20 Thread Jeff Garzik
Shaohua Li wrote: ACPI spec (ver 3.0a, p289) requires IDE power on/off executes ACPI _PSx methods. As recently most PATA drivers use libata, this patch adds _PSx method support in libata. ACPI spec doesn't mention if SATA requires the same _PSx method, but executing _PSx for SATA should be ok I

Re: [PATCH]libata-acpi: add ACPI _PSx method

2007-09-20 Thread Shaohua Li
On Thu, 2007-09-20 at 18:00 -0400, Jeff Garzik wrote: Shaohua Li wrote: ACPI spec (ver 3.0a, p289) requires IDE power on/off executes ACPI _PSx methods. As recently most PATA drivers use libata, this patch adds _PSx method support in libata. ACPI spec doesn't mention if SATA requires the

Re: [PATCH]libata-acpi: add ACPI _PSx method

2007-09-20 Thread Tejun Heo
Hello, Shaohua Li wrote: + /* channel first and then drives for power on and verse versa for power off */ + if (state.event == PM_EVENT_ON) + acpi_bus_set_power(ap-acpi_handle, ACPI_STATE_D0); + + if (ap-flags ATA_FLAG_SLAVE_POSS) + max_devices++;

[PATCH]libata-acpi: add ACPI _PSx method

2007-09-13 Thread Shaohua Li
ACPI spec (ver 3.0a, p289) requires IDE power on/off executes ACPI _PSx methods. As recently most PATA drivers use libata, this patch adds _PSx method support in libata. ACPI spec doesn't mention if SATA requires the same _PSx method, but executing _PSx for SATA should be ok I think.

Re: [PATCH]libata-acpi: add ACPI _PSx method

2007-09-13 Thread Jeff Garzik
Shaohua Li wrote: ACPI spec (ver 3.0a, p289) requires IDE power on/off executes ACPI _PSx methods. As recently most PATA drivers use libata, this patch adds _PSx method support in libata. ACPI spec doesn't mention if SATA requires the same _PSx method, but executing _PSx for SATA should be ok I

Re: [PATCH]libata-acpi: add ACPI _PSx method

2007-09-13 Thread Shaohua Li
On Thu, 2007-09-13 at 23:21 -0400, Jeff Garzik wrote: Shaohua Li wrote: ACPI spec (ver 3.0a, p289) requires IDE power on/off executes ACPI _PSx methods. As recently most PATA drivers use libata, this patch adds _PSx method support in libata. ACPI spec doesn't mention if SATA requires the