Re: [PATCH -mm] sata_nv: add suspend/resume support

2006-12-11 Thread Jeff Garzik
Robert Hancock wrote: +static void nv_remove_one (struct pci_dev *pdev) +{ + struct ata_host *host = dev_get_drvdata(&pdev->dev); + struct nv_host_priv *hpriv = host->private_data; + + kfree(hpriv); + ata_pci_remove_one(pdev); +} It is unwise to free the st

[PATCH -mm] sata_nv: add suspend/resume support

2006-11-29 Thread Robert Hancock
The attached patch is against 2.6.18-rc6-mm1, to be applied on top of the patch "sata_nv: fix ATAPI in ADMA mode" which Andrew and Jeff already have in their trees. I've only been able to test this myself by doing an aborted suspend and immediate resume and verifying it doesn't blow up in that