Re: [PATCH 01/10] libata-acpi: adjust constness in ata_acpi_gtm/stm() parameters

2007-12-17 Thread Jeff Garzik
Tejun Heo wrote: * No internal function uses const ata_port. Drop const from @ap. * Make ata_acpi_stm() copy @stm before using it and change @stm to const. Signed-off-by: Tejun Heo [EMAIL PROTECTED] --- drivers/ata/libata-acpi.c |7 --- include/linux/libata.h|4 ++-- 2

Re: [PATCH 01/10] libata-acpi: adjust constness in ata_acpi_gtm/stm() parameters

2007-12-17 Thread Jeff Garzik
Tejun Heo wrote: * No internal function uses const ata_port. Drop const from @ap. * Make ata_acpi_stm() copy @stm before using it and change @stm to const. for the record, I -would- use const ata_port where feasible; its just so rarely feasible, since members of that struct are often

[PATCH 01/10] libata-acpi: adjust constness in ata_acpi_gtm/stm() parameters

2007-12-14 Thread Tejun Heo
* No internal function uses const ata_port. Drop const from @ap. * Make ata_acpi_stm() copy @stm before using it and change @stm to const. Signed-off-by: Tejun Heo [EMAIL PROTECTED] --- drivers/ata/libata-acpi.c |7 --- include/linux/libata.h|4 ++-- 2 files changed, 6