Re: [PATCH 02/12] libata: implement AC_ERR_NCQ

2007-07-03 Thread Tejun Heo
Jeff Garzik wrote: > Tejun Heo wrote: >> +++ b/include/linux/libata.h >> @@ -322,7 +322,8 @@ enum ata_completion_errors { >> AC_ERR_SYSTEM= (1 << 6), /* system error */ >> AC_ERR_INVALID= (1 << 7), /* invalid argument */ >> AC_ERR_OTHER= (1 << 8), /* unknown *

Re: [PATCH 02/12] libata: implement AC_ERR_NCQ

2007-07-03 Thread Jeff Garzik
Tejun Heo wrote: +++ b/include/linux/libata.h @@ -322,7 +322,8 @@ enum ata_completion_errors { AC_ERR_SYSTEM = (1 << 6), /* system error */ AC_ERR_INVALID = (1 << 7), /* invalid argument */ AC_ERR_OTHER= (1 << 8), /* unknown */ - AC_ERR

[PATCH 02/12] libata: implement AC_ERR_NCQ

2007-07-01 Thread Tejun Heo
When an NCQ command fails, all commands in flight are aborted and the offending one is reported using log page 10h. Depending on controller characteristics and LLD implementation, all commands may appear as having a device error due to shared TF status making it hard to determine what's actually g