Re: [PATCH 02/21] libata: add @is_cmd to ata_tf_to_fis()

2007-07-20 Thread Jeff Garzik
Tejun Heo wrote: Jeff Garzik wrote: Tejun Heo wrote: Add @is_cmd to ata_tf_to_fis(). This controls bit 7 of the second byte which tells the device whether this H2D FIS is for a command or not. This cleans up ahci a bit and will be used by PMP. Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> ---

Re: [PATCH 02/21] libata: add @is_cmd to ata_tf_to_fis()

2007-07-20 Thread Tejun Heo
Jeff Garzik wrote: > Tejun Heo wrote: >> Add @is_cmd to ata_tf_to_fis(). This controls bit 7 of the second >> byte which tells the device whether this H2D FIS is for a command or >> not. This cleans up ahci a bit and will be used by PMP. >> >> Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> >> --- >

Re: [PATCH 02/21] libata: add @is_cmd to ata_tf_to_fis()

2007-07-20 Thread Jeff Garzik
Tejun Heo wrote: Add @is_cmd to ata_tf_to_fis(). This controls bit 7 of the second byte which tells the device whether this H2D FIS is for a command or not. This cleans up ahci a bit and will be used by PMP. Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> --- drivers/ata/ahci.c| 10 +++

Re: [PATCH 02/21] libata: add @is_cmd to ata_tf_to_fis()

2007-07-20 Thread Jeff Garzik
Tejun Heo wrote: +extern void ata_tf_to_fis(const struct ata_taskfile *tf, + u8 pmp, int is_cmd, u8 *fis); I'm applying these... but I would like to start seeing 'bool' type used for arguments like "is_cmd", for situations where the only values we -ever- care about ar

[PATCH 02/21] libata: add @is_cmd to ata_tf_to_fis()

2007-07-15 Thread Tejun Heo
Add @is_cmd to ata_tf_to_fis(). This controls bit 7 of the second byte which tells the device whether this H2D FIS is for a command or not. This cleans up ahci a bit and will be used by PMP. Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> --- drivers/ata/ahci.c| 10 -- drivers/at