Re: [PATCH 11/11] ide-pmac: remove pmac_ide_do_setfeature() (take 2)

2007-07-26 Thread Bartlomiej Zolnierkiewicz
On Tuesday 24 July 2007, Benjamin Herrenschmidt wrote: On Tue, 2007-07-24 at 00:29 +0200, Bartlomiej Zolnierkiewicz wrote: Use ide_config_drive_speed() instead of pmac_ide_do_setfeature() and remove the latter, also ide-iops.c::__ide_wait_stat() could be static again. Since for IDE PMAC

Re: [PATCH 11/11] ide-pmac: remove pmac_ide_do_setfeature() (take 2)

2007-07-26 Thread Benjamin Herrenschmidt
On Thu, 2007-07-26 at 20:04 +0200, Bartlomiej Zolnierkiewicz wrote: On Tuesday 24 July 2007, Benjamin Herrenschmidt wrote: On Tue, 2007-07-24 at 00:29 +0200, Bartlomiej Zolnierkiewicz wrote: Use ide_config_drive_speed() instead of pmac_ide_do_setfeature() and remove the latter, also

[PATCH 11/11] ide-pmac: remove pmac_ide_do_setfeature() (take 2)

2007-07-23 Thread Bartlomiej Zolnierkiewicz
Use ide_config_drive_speed() instead of pmac_ide_do_setfeature() and remove the latter, also ide-iops.c::__ide_wait_stat() could be static again. Since for IDE PMAC host driver IDE_CONTROL_REG is always true, device's -quirk_list is always zero and -ide_dma_host_{on,off} are nops than the only