Re: [PATCH 2/2] ata_piix: fix suspend/resume for some TOSHIBA laptops

2007-07-24 Thread Jeff Garzik
Tejun Heo wrote: + /* Some braindamaged ACPI suspend implementations expect the +* controller to be awake on entry; otherwise, it burns cpu +* cycles and power trying to do something to the sleeping +* beauty. +*/ applied 1-2... HOWEVER... I would not

Re: [PATCH 2/2] ata_piix: fix suspend/resume for some TOSHIBA laptops

2007-07-24 Thread Jeff Garzik
Alan Cox wrote: A more generalized rule to consider for the future would be to ensure that ALL suspend routines put the hardware back into its pre-Linux init mode before suspending. i.e. that means if we turned on some enhanced mode, we must switch back to legacy mode before calling pci_xxx

[PATCH 2/2] ata_piix: fix suspend/resume for some TOSHIBA laptops

2007-07-10 Thread Tejun Heo
ACPI implementations in several TOSHIBA laptops are weird and burn cpu cycles for tens of seconds while trying to suspend if the PCI device for the ATA controller is disabled when the ACPI suspend is called. This patch uses DMI to match those machines and bypass device disable on those machines