On Thu, Dec 20, 2007 at 09:53:54PM +, Adrian McMenamin wrote:
> On 16/12/2007, Paul Mundt <[EMAIL PROTECTED]> wrote:
> > Also, __devinit/__devexit annotations?
> >
>
> Is there any difference between __init and __devint?
Yes.
-
To unsubscribe from this list: send the line "unsubscribe linux-i
On 16/12/2007, Paul Mundt <[EMAIL PROTECTED]> wrote:
>
> Also, __devinit/__devexit annotations?
>
Is there any difference between __init and __devint? I am using
__init/__exit already
> > +static struct platform_driver gdrom_driver = {
> > + .probe = probe_gdrom,
> > + .remove = remove_g
On Dec 16 2007 18:50, Paul Mundt wrote:
>On Sun, Dec 16, 2007 at 12:21:21AM +, Adrian McMenamin wrote:
>> +/* GD Rom registers */
>> +#define GDROM_BASE_REG 0xA05F7000
>> +#define GDROM_ALTSTATUS_REG GDROM_BASE_REG + 0x18
>> +#define GDROM_DATA_REG GDROM_BASE_REG + 0x80
>> +#define GDROM_ERROR
On Mon, December 17, 2007 2:06 pm, Jens Axboe wrote:
> On Sun, Dec 16 2007, Adrian McMenamin wrote:
>
> Few notes:
Thanks for these, very helpful.
>
> - Compare rq_data_dir() with WRITE, don't just assume that any non-zero
> will be a write.
>
> - You need to offload this request handling to a
On Sun, Dec 16 2007, Adrian McMenamin wrote:
> +static int gdrom_readdisk_dma(int block, int block_cnt, char *buffer)
> +{
> + int err;
> + struct packet_command *read_command;
> + /* release the spin lock but check later
> + * we're not in the middle of some dma */
> + spin_un
On Mon, 2007-12-17 at 06:59 +0900, Paul Mundt wrote:
>
> While I realize that this is all undocumented and based entirely on
> reverse engineering, you should at least verify that that's precisely
> what is going on, and that this is not just a precaution for flushing
> posted writes. You can te
On Sun, Dec 16, 2007 at 05:32:51PM +, Adrian McMenamin wrote:
> On Sun, 2007-12-16 at 18:50 +0900, Paul Mundt wrote:
> > > + for (count = 0xa000; count < 0xa020; count += 4)
> > > + ctrl_inl(count);
> >
> > Er? This ranged dummy reading of the P2 space needs some explanation. T
On Saturday 15 December 2007, Adrian McMenamin wrote:
> diff -ruN ./linux-2.6-orig/drivers/sh/gdrom/gdrom.c
> ./linux-2.6/drivers/sh/gdrom/gdrom.c
i think your e-mail client word wrapped a little ...
> + if (gd.toc)
> + kfree(gd.toc);
i dont know how the kernel functions, but in
On Sun, 2007-12-16 at 18:50 +0900, Paul Mundt wrote:
> > +static int gdrom_readdisk_dma(int block, int block_cnt, char *buffer)
> > +{
> > + int err;
> > + struct packet_command *read_command;
> > + /* release the spin lock but check later
> > +* we're not in the middle of some dma */
>
On Sun, 2007-12-16 at 18:50 +0900, Paul Mundt wrote:
> Ok, I don't know anything about the CD-ROM layer, so I've just commented
> on the general and SH-specific stuff. Hopefully someone with a clue
> in this area (ie, not me) can offer input on the rest of the bits.
>
> > +static char gdrom_exec
On Sun, Dec 16, 2007 at 06:50:19PM +0900, Paul Mundt wrote:
> > +static irqreturn_t gdrom_command_interrupt(int irq, void *dev_id)
> > +{
> > + if (dev_id != &gd)
> > + return IRQ_NONE;
>
> You aren't setting this up as a shared IRQ, so this shouldn't be
> necessary.
It's not nessecar
Ok, I don't know anything about the CD-ROM layer, so I've just commented
on the general and SH-specific stuff. Hopefully someone with a clue
in this area (ie, not me) can offer input on the rest of the bits.
On Sun, Dec 16, 2007 at 12:21:21AM +, Adrian McMenamin wrote:
> +/* GD Rom registers *
diff -ruN ./linux-2.6-orig/drivers/sh/gdrom/gdrom.c
./linux-2.6/drivers/sh/gdrom/gdrom.c
--- ./linux-2.6-orig/drivers/sh/gdrom/gdrom.c 1970-01-01
01:00:00.0 +0100
+++ ./linux-2.6/drivers/sh/gdrom/gdrom.c2007-12-15 22:58:17.0
+
@@ -0,0 +1,793 @@
+/* GD ROM driver for t
13 matches
Mail list logo
