Re: [PATCH 2/3] libata ata_data_xfer() fix

2005-08-02 Thread Albert Lee
Jeff Garzik wrote: Thanks. Needs one last change: don't use the ioxxx_rep() / {out,in}sw() functions for the trailing bits. You are guaranteed to only ever need a single iteration. You're right. Attached please find the revised patch for your review. I made a design decision to -n

Re: [PATCH 2/3] libata ata_data_xfer() fix

2005-08-01 Thread Jeff Garzik
Albert Lee wrote: ok. Attached please find the revised patch with 32-bit IO removed for your review. PATCH 2/3: ata_data_xfer() fix Changes: - Modify ata_mmio_data_xfer() and ata_pio_data_xfer() to handle buffer length not aligned to 16-bit boundary. Thanks. Needs one last change:

Re: [PATCH 2/3] libata ata_data_xfer() fix

2005-08-01 Thread Albert Lee
Jeff Garzik wrote: Albert Lee wrote: Jeff, PATCH 2/3: ata_data_xfer() fix Changes: - Add ATA_FLAG_IO_32BIT to libata.h for hosts with 32-bit data register. - Modify ata_mmio_data_xfer() and ata_pio_data_xfer() to handle buffer length not aligned to 32-bit boundary. This patch d

Re: [PATCH 2/3] libata ata_data_xfer() fix

2005-08-01 Thread Jeff Garzik
Albert Lee wrote: Jeff, PATCH 2/3: ata_data_xfer() fix Changes: - Add ATA_FLAG_IO_32BIT to libata.h for hosts with 32-bit data register. - Modify ata_mmio_data_xfer() and ata_pio_data_xfer() to handle buffer length not aligned to 32-bit boundary. This patch does not reuse ap->pad as

[PATCH 2/3] libata ata_data_xfer() fix

2005-08-01 Thread Albert Lee
Jeff, PATCH 2/3: ata_data_xfer() fix Changes: - Add ATA_FLAG_IO_32BIT to libata.h for hosts with 32-bit data register. - Modify ata_mmio_data_xfer() and ata_pio_data_xfer() to handle buffer length not aligned to 32-bit boundary. This patch does not reuse ap->pad as alignment buffer sinc