Re: [PATCH 2/5] ide: remove redundant BUG_ON() from [atapi_]reset_pollfunc()

2008-02-07 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Same BUG_ON() is present inside ide_set_handler(). There is no BUG_ON there -- __ide_set_handler() has a check for the same condition and a printk(KERN_CRIT)... myabe it should be replaced with BUG_ON()... Yeah, you're right - care to make a patch?

Re: [PATCH 2/5] ide: remove redundant BUG_ON() from [atapi_]reset_pollfunc()

2008-02-06 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Same BUG_ON() is present inside ide_set_handler(). There is no BUG_ON there -- __ide_set_handler() has a check for the same condition and a printk(KERN_CRIT)... myabe it should be replaced with BUG_ON()... Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL

Re: [PATCH 2/5] ide: remove redundant BUG_ON() from [atapi_]reset_pollfunc()

2008-02-06 Thread Bartlomiej Zolnierkiewicz
On Wednesday 06 February 2008, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: Same BUG_ON() is present inside ide_set_handler(). There is no BUG_ON there -- __ide_set_handler() has a check for the same condition and a printk(KERN_CRIT)... myabe it should be replaced with