Re: [PATCH 2/7] sata_promise: pdc_freeze() semantic change

2007-10-02 Thread Jeff Garzik
Albert Lee wrote: After checking the current implementations of freeze()/thaw(), it seems only pdc_freeze() does more than simple irq masking. Remove the DMA stop code from pdc_freeze(). Signed-off-by: Albert Lee <[EMAIL PROTECTED]> --- diff -Nrup 01_remove_leftover_irqon/drivers/ata/sata_pro

Re: [PATCH 2/7] sata_promise: pdc_freeze() semantic change

2007-07-16 Thread Albert Lee
Tejun Heo wrote: > Tejun Heo wrote: > >>Mikael Pettersson wrote: >> >>>Albert's patch is OK as far as sata_promise is concerned, but >>>I want to see an update of libata.tmpl and libata-eh.c to >>>indicate the new, weakened, specification of freeze/thaw before >>>I ACK this patch. > > > Hmmm

Re: [PATCH 2/7] sata_promise: pdc_freeze() semantic change

2007-07-13 Thread Tejun Heo
Tejun Heo wrote: > Mikael Pettersson wrote: >> Albert's patch is OK as far as sata_promise is concerned, but >> I want to see an update of libata.tmpl and libata-eh.c to >> indicate the new, weakened, specification of freeze/thaw before >> I ACK this patch. Hmmm The docbook document is too sta

Re: [PATCH 2/7] sata_promise: pdc_freeze() semantic change

2007-07-10 Thread Tejun Heo
Mikael Pettersson wrote: > Albert's patch is OK as far as sata_promise is concerned, but > I want to see an update of libata.tmpl and libata-eh.c to > indicate the new, weakened, specification of freeze/thaw before > I ACK this patch. Aye aye sir. -- tejun - To unsubscribe from this list: send t

Re: [PATCH 2/7] sata_promise: pdc_freeze() semantic change

2007-07-07 Thread Mikael Pettersson
On Sat, 07 Jul 2007 15:02:49 +0800, Albert Lee wrote: > After checking the current implementations of freeze()/thaw(), it seems only > pdc_freeze() >does more than simple irq masking. Remove the DMA stop code from pdc_freeze(). > >Signed-off-by: Albert Lee <[EMAIL PROTECTED]> >--- > >diff -Nrup 01

[PATCH 2/7] sata_promise: pdc_freeze() semantic change

2007-07-07 Thread Albert Lee
After checking the current implementations of freeze()/thaw(), it seems only pdc_freeze() does more than simple irq masking. Remove the DMA stop code from pdc_freeze(). Signed-off-by: Albert Lee <[EMAIL PROTECTED]> --- diff -Nrup 01_remove_leftover_irqon/drivers/ata/sata_promise.c 02_sata_pdc_