Jeff Garzik wrote:
applied
There are some issues with this. One of which I fixed and the other is
a bit confusing. The one I fixed concerned the 5xxx chips not
supporting the master reset functionality. The other problem has been
reported by 2 people so far. I have a stack trace from
On Wed, 7 Sep 2005, Brett Russ wrote:
The one I fixed concerned the 5xxx chips not supporting the master
reset functionality.
Please note that in my case the failure to do master reset is followed
by the module still being loaded and oops-ing at rmmod, which means
that the error path in the
Brett Russ wrote:
Some (non-functional) cleanup modifications since the version 0.10
driver I sent out 2005-08-30. Also adding signed-off-by for Jeff's
upstream push. This is my libata compatible low level driver for
the Marvell SATA family. Currently it successfully runs in PIO mode
on a
Tyler wrote:
Brett Russ wrote:
Some (non-functional) cleanup modifications since the version 0.10
driver I sent out 2005-08-30. Also adding signed-off-by for Jeff's
upstream push. This is my libata compatible low level driver for
the Marvell SATA family. Currently it successfully runs in
On Thu, 1 Sep 2005, Brett Russ wrote:
This is my libata compatible low level driver for the Marvell SATA
family.
First of all, thanks! I've been waiting for such a driver to appear.
I somehow did not manage to get a working 2.6.13 kernel to boot and,
as I didn't have too much time to see why,
Some (non-functional) cleanup modifications since the version 0.10
driver I sent out 2005-08-30. Also adding signed-off-by for Jeff's
upstream push. This is my libata compatible low level driver for
the Marvell SATA family. Currently it successfully runs in PIO mode
on a 6081 chip. EDMA
+#include linux/kernel.h
+#include linux/module.h
+#include linux/pci.h
+#include linux/init.h
+#include linux/blkdev.h
+#include linux/delay.h
+#include linux/interrupt.h
+#include linux/sched.h
+#include linux/dma-mapping.h
+#include scsi.h
pleaese don't include scsi.h in new drivers.
Jeff Garzik wrote:
As I said, the include does away simultaneously for all libata drivers.
s/does/goes/
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Christoph Hellwig wrote:
On Thu, Sep 01, 2005 at 03:48:51PM -0400, Jeff Garzik wrote:
Christoph Hellwig wrote:
+#include linux/kernel.h
+#include linux/module.h
+#include linux/pci.h
+#include linux/init.h
+#include linux/blkdev.h
+#include linux/delay.h
+#include linux/interrupt.h
+#include
On Thu, Sep 01, 2005 at 04:03:27PM -0400, Jeff Garzik wrote:
Christoph Hellwig wrote:
On Thu, Sep 01, 2005 at 03:48:51PM -0400, Jeff Garzik wrote:
Christoph Hellwig wrote:
+#include linux/kernel.h
+#include linux/module.h
+#include linux/pci.h
+#include linux/init.h
+#include
Christoph Hellwig wrote:
Stop that crap now please. Adding scsi.h includes is _not_ allowed
for new drivers, period. There's no exceptions, not even for
Jeff I'm part of the calal Garzik.
There are solid technical reasons (a) why libata drivers include scsi.h,
and (b) why all libata drivers
Christoph Hellwig wrote:
+#include linux/kernel.h
+#include linux/module.h
+#include linux/pci.h
+#include linux/init.h
+#include linux/blkdev.h
+#include linux/delay.h
+#include linux/interrupt.h
+#include linux/sched.h
+#include linux/dma-mapping.h
+#include scsi.h
pleaese don't include
More (non-functional) style modifications since the version 0.11
driver I sent out earlier today. Removed most parens around return
value, corrected indentation of labels, improved comment for flush,
removed naked return, and cleanup ata_qc_from_tag() call block.
This is my libata compatible low
Brett Russ wrote:
This is my libata compatible low level driver for the Marvell SATA
family. Currently it successfully runs in PIO mode on a 6081 chip.
EDMA support is in the works and should be done shortly. Review,
testing (especially on other flavors of Marvell), comments welcome.
Note
14 matches
Mail list logo
