Re: [PATCH 2.6.21-rc1 2/2] sata_vsc: clean up vsc_sata_interrupt

2007-02-22 Thread Tejun Heo
Hello, Just one nit. Dan Williams wrote: + if (unlikely(status == 0x || status == 0)) { + status printk(KERN_ERR DRV_NAME : IRQ status == 0x, + PCI fault or device removal?\n); People usually don't like using logical operator short

[PATCH 2.6.21-rc1 2/2] sata_vsc: clean up vsc_sata_interrupt

2007-02-21 Thread Dan Williams
1/ Clean up vsc_sata_interrupt and have it call vsc_port_intr to handle the interrupt. 2/ Hook up vsc_freeze and vsc_thaw in vsc_sata_ops 3/ Remove the now unnecessary is_vsc_sata_int_err Tested with an iq3124h PCI-X add-in card on an iop13xx. Changes in take2 * revert changes to