Re: [PATCH 2.6.22-rc7] libata: quirk IOMEGA ZIP 250 ATAPI FLOPPY

2007-07-10 Thread Jeff Garzik
Tejun Heo wrote: The Zip 250 which chokes on MWDMA SET_XFERMODE sometimes have Floppy appeneded to its model number. Quirk it too. http://bugzilla.kernel.org/show_bug.cgi?id=8563 Signed-off-by: Tejun Heo [EMAIL PROTECTED] Cc: Hans de Bruin [EMAIL PROTECTED] --- It seems the Zip 250 mwdma

Re: [PATCH 2.6.22-rc7] libata: quirk IOMEGA ZIP 250 ATAPI FLOPPY

2007-07-06 Thread Tejun Heo
Jeff Garzik wrote: Alan Cox wrote: but IDE simply ignores the error and continues to operate in MWDMA mode, so I guess we can remove the 'temporary fix' comment or add another quirk type - ATA_HORKAGE_SETXFER_MAY_FAIL - and use it. Should we warn in these cases ? Or issue a new identify and

Re: [PATCH 2.6.22-rc7] libata: quirk IOMEGA ZIP 250 ATAPI FLOPPY

2007-07-05 Thread Alan Cox
but IDE simply ignores the error and continues to operate in MWDMA mode, so I guess we can remove the 'temporary fix' comment or add another quirk type - ATA_HORKAGE_SETXFER_MAY_FAIL - and use it. Should we warn in these cases ? Or issue a new identify and check the mode activated ? Alan - To