Re: [PATCH 2.6.24-rc1] sata_promise: ASIC PRD table bug workaround

2007-10-30 Thread Mikael Pettersson
On Mon, 29 Oct 2007 15:07:06 -0400, Jeff Garzik wrote: Mikael Pettersson wrote: @@ -155,7 +155,7 @@ static struct scsi_host_template pdc_ata .queuecommand = ata_scsi_queuecmd, .can_queue = ATA_DEF_QUEUE, .this_id= ATA_SHT_THIS_ID, -

Re: [PATCH 2.6.24-rc1] sata_promise: ASIC PRD table bug workaround

2007-10-30 Thread Alexander Sabourenkov
Mikael Pettersson wrote: Unfortunately the name pdc_qc_prep() is already taken [it switches on qc-tf.protocol], so that leaves either pdc_fill_sg() [slightly imprecise as you noted], or uglies like __pdc_qc_prep(), pdc_qc_prep2(), or pdc_qc_prep_and_fill_sg() as names for the new procedure. I

Re: [PATCH 2.6.24-rc1] sata_promise: ASIC PRD table bug workaround

2007-10-29 Thread Alexander Sabourenkov
Jeff Garzik wrote: Mikael Pettersson wrote: @@ -530,7 +608,7 @@ static void pdc_qc_prep(struct ata_queue switch (qc-tf.protocol) { case ATA_PROT_DMA: -ata_qc_prep(qc); +pdc_fill_sg(qc); /* fall through */ case ATA_PROT_NODATA: @@ -546,11 +624,11