[PATCH 3/3 RESEND] Add disk hotswap support to libata

2005-07-22 Thread Lukasz Kosewski
Hey Jeff, everyone. This is a resend of patch 3 of my libata hotswap series, wherein I found a silly flaw in my logic. I don't know what kind of crack I was smoking, but I somehow turned "a = a & ~b" in the Promise driver into "a = a ^ b" in my hotswap code, which is clearly wrong. I don't know

Re: [PATCH 3/3 RESEND] Add disk hotswap support to libata

2005-07-26 Thread Jeff Garzik
Lukasz Kosewski wrote: Hey Jeff, everyone. This is a resend of patch 3 of my libata hotswap series, wherein I found a silly flaw in my logic. I don't know what kind of crack I was smoking, but I somehow turned "a = a & ~b" in the Promise driver into "a = a ^ b" in my hotswap code, which is clea

Re: [PATCH 3/3 RESEND] Add disk hotswap support to libata

2005-07-31 Thread Lukasz Kosewski
On 7/26/05, Jeff Garzik <[EMAIL PROTECTED]> wrote: > > +static void pdc2_phy_reset(struct ata_port *ap) > > +{ > > + /* As observed on the Promise SATAII150 Tx2 Plus/Tx4, giving the > > + * controller a hard reset triggers another hotplug interrupt. So > > + * disable them for the ha