Re: [PATCH 3/6] ide-pmac: PIO fixes

2007-07-13 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: * Add { 0, 0 } entry to {kauai,shasta}_pio_timings[] so kauai_lookup_timing() always returns a valid PIO timing (fixes PIO timing not being set for devices with minimum PIO cycle = 120ns). Ugh... the way those tables are following each other,

Re: [PATCH 3/6] ide-pmac: PIO fixes

2007-07-13 Thread Bartlomiej Zolnierkiewicz
On Friday 13 July 2007, Sergei Shtylyov wrote: Hello. Bartlomiej Zolnierkiewicz wrote: * Add { 0, 0 } entry to {kauai,shasta}_pio_timings[] so kauai_lookup_timing() always returns a valid PIO timing (fixes PIO timing not being set for devices with minimum PIO cycle = 120ns).

Re: [PATCH 3/6] ide-pmac: PIO fixes

2007-07-12 Thread Bartlomiej Zolnierkiewicz
On Wednesday 11 July 2007, Bartlomiej Zolnierkiewicz wrote: * Add { 0, 0 } entry to {kauai,shasta}_pio_timings[] so kauai_lookup_timing() always returns a valid PIO timing (fixes PIO timing not being set for devices with minimum PIO cycle = 120ns). * Add setting transfer mode on the

Re: [PATCH 3/6] ide-pmac: PIO fixes

2007-07-12 Thread Benjamin Herrenschmidt
This patch should have no effect on the default kernel behavior because IDE pmac driver doesn't enable -autotune (this would also explain why some of the above bugs remained unfixed for so long). This part of the patch description is actually incorrect: -tuneproc is used unconditionally