Re: [PATCH 5/13] ide: add IDE_HFLAG_ERROR_STOPS_FIFO host flag

2007-09-08 Thread Alan Cox
On Thu, 6 Sep 2007 04:13:56 -0400 Jeff Garzik [EMAIL PROTECTED] wrote: On Wed, Sep 05, 2007 at 11:52:57PM +0200, Bartlomiej Zolnierkiewicz wrote: Add IDE_HFLAG_ERROR_STOPS_FIFO host flag and use it instead of hwif-err_stops_fifo. As a side-effect this change fixes hwif-err_stops_fifo

Re: [PATCH 5/13] ide: add IDE_HFLAG_ERROR_STOPS_FIFO host flag

2007-09-08 Thread Alan Cox
You'd have to add the drain data on error hack first, right now we will reset in that case (which for one or two devices has another problem in that it won't clear a stuck FIFO) Nod. There was nothing ever wrong with Mark's drain patch, I just never saw a solid justification for it

Re: [PATCH 5/13] ide: add IDE_HFLAG_ERROR_STOPS_FIFO host flag

2007-09-08 Thread Jeff Garzik
Alan Cox wrote: You'd have to add the drain data on error hack first, right now we will reset in that case (which for one or two devices has another problem in that it won't clear a stuck FIFO) Nod. There was nothing ever wrong with Mark's drain patch, I just never saw a solid justification

Re: [PATCH 5/13] ide: add IDE_HFLAG_ERROR_STOPS_FIFO host flag

2007-09-06 Thread Jeff Garzik
On Wed, Sep 05, 2007 at 11:52:57PM +0200, Bartlomiej Zolnierkiewicz wrote: Add IDE_HFLAG_ERROR_STOPS_FIFO host flag and use it instead of hwif-err_stops_fifo. As a side-effect this change fixes hwif-err_stops_fifo not being restored by ide_hwif_restore(). Signed-off-by: Bartlomiej

[PATCH 5/13] ide: add IDE_HFLAG_ERROR_STOPS_FIFO host flag

2007-09-05 Thread Bartlomiej Zolnierkiewicz
Add IDE_HFLAG_ERROR_STOPS_FIFO host flag and use it instead of hwif-err_stops_fifo. As a side-effect this change fixes hwif-err_stops_fifo not being restored by ide_hwif_restore(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-io.c |3 ++-