Re: [PATCH 5/7] libata: integrate freeze/thaw with irq_on/off

2007-07-16 Thread Albert Lee
Tejun Heo wrote: > Hello, > > >>+void ata_irq_on(struct ata_port *ap) >> { >> struct ata_ioports *ioaddr = &ap->ioaddr; >>- u8 tmp; >> >> ap->ctl &= ~ATA_NIEN; >> ap->last_ctl = ap->ctl; >> >> iowrite8(ap->ctl, ioaddr->ctl_addr); >>- tmp = ata_wait_idle(ap); >>+

Re: [PATCH 5/7] libata: integrate freeze/thaw with irq_on/off

2007-07-13 Thread Tejun Heo
Hello, > +void ata_irq_on(struct ata_port *ap) > { > struct ata_ioports *ioaddr = &ap->ioaddr; > - u8 tmp; > > ap->ctl &= ~ATA_NIEN; > ap->last_ctl = ap->ctl; > > iowrite8(ap->ctl, ioaddr->ctl_addr); > - tmp = ata_wait_idle(ap); > + ata_wait_idle(ap); > >