[PATCH 9/15] cs5530: remove needless ide_lock taking

2007-10-01 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/pci/cs5530.c |8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) Index: b/drivers/ide/pci/cs5530.c === --- a/drivers/ide/pci/cs5530.c +++ b/dri

Re: [PATCH 9/15] cs5530: remove needless ide_lock taking

2007-10-02 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]> MBR, Sergei - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH 9/15] cs5530: remove needless ide_lock taking

2007-10-02 Thread Alan Cox
> - spin_lock_irqsave(&ide_lock, flags); > - /* all CPUs (there should only be one CPU with this chipset) */ > - NAK What about pre-emptible kernels. Put in a private lock. Alan - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EM

Re: [PATCH 9/15] cs5530: remove needless ide_lock taking

2007-10-02 Thread Bartlomiej Zolnierkiewicz
On Tuesday 02 October 2007, Alan Cox wrote: > > - spin_lock_irqsave(&ide_lock, flags); > > - /* all CPUs (there should only be one CPU with this chipset) */ > > - > > NAK > > What about pre-emptible kernels. Put in a private lock. All the removed code resided in init_chipset_cs5530()

Re: [PATCH 9/15] cs5530: remove needless ide_lock taking

2007-10-02 Thread Alan Cox
> All the removed code resided in init_chipset_cs5530() which is called only > during the controller initialization. Moreover pata_cs5530 also don't have > any locking in cs5530_init_chip(). Fair enough, and I haven't found a reason for the locking being needed from doc reviews (hence its not in