Sergei Shtylyov wrote:
Hello.
Bartlomiej Zolnierkiewicz wrote:
* Add ATA_PIO[0-6] defines to linux/ata.h.
* Add -pio_mask field to ide_pci_device_t and ide_hwif_t.
* Add PIO masks to host drivers.
Hm, the next logical step would be to use the mask constants in
linux/ata.h for the
It doesn't need to do anything.
Not true. It should call ide_config_drive_speed() at least, else PIO
autotuning won't actually work.
Indeed - I forgot that old-ide doesn't do this itself but leaves it up to
the driver to forget 8)
-
To unsubscribe from this list: send the line
On Wednesday 04 July 2007, Alan Cox wrote:
It doesn't need to do anything.
Not true. It should call ide_config_drive_speed() at least, else PIO
autotuning won't actually work.
Indeed - I forgot that old-ide doesn't do this itself but leaves it up to
the driver to forget 8)
OK,
Hello.
Bartlomiej Zolnierkiewicz wrote:
* Add ATA_PIO[0-6] defines to linux/ata.h.
* Add -pio_mask field to ide_pci_device_t and ide_hwif_t.
* Add PIO masks to host drivers.
Hm, the next logical step would be to use the mask constants in
linux/ata.h for the drivers' DMA caps too...
On Tuesday 03 July 2007, Sergei Shtylyov wrote:
Hello.
Bartlomiej Zolnierkiewicz wrote:
* Add ATA_PIO[0-6] defines to linux/ata.h.
* Add -pio_mask field to ide_pci_device_t and ide_hwif_t.
* Add PIO masks to host drivers.
Hm, the next logical step would be to use the mask
.bootable = ON_BOARD, \
.enablebits = { {0x40, 1, 1}, {0x40, 0x10, 0x10} }, \
+ .pio_mask = ATA_PIO5, \
}
Just noticed that this driver does nothing in its tuneproc() method. So,
this mask is
* Add ATA_PIO[0-6] defines to linux/ata.h.
* Add -pio_mask field to ide_pci_device_t and ide_hwif_t.
* Add PIO masks to host drivers.
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
---
drivers/ide/cris/ide-cris.c|1 +
drivers/ide/ide.c |2 ++
Bartlomiej Zolnierkiewicz wrote:
* Add ATA_PIO[0-6] defines to linux/ata.h.
ACK
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
