[PATCH libata-dev#upstream-fixes] libata: fix drive side 80c cable check

2007-02-04 Thread Tejun Heo
The 80c wire bit is bit 13, not 14. Bit 14 is always 1 if word93 is implemented. This increases the chance of incorrect wire detection especially because host side cable detection is often unreliable and we sometimes soley depend on drive side cable detection. Fix it. Signed-off-by: Tejun Heo <

Re: [PATCH libata-dev#upstream-fixes] libata: fix drive side 80c cable check

2007-02-05 Thread Alan
On Mon, 5 Feb 2007 16:45:35 +0900 Tejun Heo <[EMAIL PROTECTED]> wrote: > The 80c wire bit is bit 13, not 14. Bit 14 is always 1 if word93 is > implemented. This increases the chance of incorrect wire detection > especially because host side cable detection is often unreliable and > we sometimes

[PATCH libata-dev#upstream-fixes] libata: fix drive side 80c cable check, take 2

2007-02-05 Thread Tejun Heo
The 80c wire bit is bit 13, not 14. Bit 14 is always 1 if word93 is implemented. This increases the chance of incorrect wire detection especially because host side cable detection is often unreliable and we sometimes soley depend on drive side cable detection. Fix the test and add word93 validit

[PATCH libata-dev#upstream-fixes] libata: fix drive side 80c cable check, take 3

2007-02-05 Thread Tejun Heo
The 80c wire bit is bit 13, not 14. Bit 14 is always 1 if word93 is implemented. This increases the chance of incorrect wire detection especially because host side cable detection is often unreliable and we sometimes soley depend on drive side cable detection. Fix the test and add word93 validit

Re: [PATCH libata-dev#upstream-fixes] libata: fix drive side 80c cable check, take 2

2007-02-05 Thread Alan
On Mon, 5 Feb 2007 21:41:06 +0900 Tejun Heo <[EMAIL PROTECTED]> wrote: > The 80c wire bit is bit 13, not 14. Bit 14 is always 1 if word93 is > implemented. This increases the chance of incorrect wire detection > especially because host side cable detection is often unreliable and > we sometimes

Re: [PATCH libata-dev#upstream-fixes] libata: fix drive side 80c cable check, take 3

2007-02-05 Thread Alan
On Mon, 5 Feb 2007 23:21:19 +0900 Tejun Heo <[EMAIL PROTECTED]> wrote: > The 80c wire bit is bit 13, not 14. Bit 14 is always 1 if word93 is > implemented. This increases the chance of incorrect wire detection > especially because host side cable detection is often unreliable and > we sometimes

Re: [PATCH libata-dev#upstream-fixes] libata: fix drive side 80c cable check, take 3

2007-02-15 Thread Jeff Garzik
Tejun Heo wrote: The 80c wire bit is bit 13, not 14. Bit 14 is always 1 if word93 is implemented. This increases the chance of incorrect wire detection especially because host side cable detection is often unreliable and we sometimes soley depend on drive side cable detection. Fix the test and

Re: [PATCH libata-dev#upstream-fixes] libata: fix drive side 80c cable check, take 3

2007-07-12 Thread Sergei Shtylyov
Tejun Heo wrote: The 80c wire bit is bit 13, not 14. Bit 14 is always 1 if word93 is implemented. This increases the chance of incorrect wire detection especially because host side cable detection is often unreliable and we sometimes soley depend on drive side cable detection. Fix the test an

Re: [PATCH libata-dev#upstream-fixes] libata: fix drive side 80c cable check, take 3

2007-07-12 Thread Sergei Shtylyov
Hello, I wrote: The 80c wire bit is bit 13, not 14. Bit 14 is always 1 if word93 is implemented. This increases the chance of incorrect wire detection especially because host side cable detection is often unreliable and we sometimes soley depend on drive side cable detection. Fix the test and

Re: [PATCH libata-dev#upstream-fixes] libata: fix drive side 80c cable check, take 3

2007-07-12 Thread Tejun Heo
Sergei Shtylyov wrote: >>Wrong, wrong as well! The correct value to compare with would be >> 0x4000. > >Sorry for the false alarm -- those opposite senses on CBLID- have > really confused me. :-< Yeah, all those cable detection mess plays tricks on minds. PATA is really screwed up in tha