Re: [PATCH libata-dev-2.6 1/3] Add CHS support

2005-02-21 Thread Albert Lee
Jeff, > Applied patches 1 and 2 of the first CHS series, > and patches 3-1 through 3-3 of the second CHS series, to libata-dev queue. > Thanks. > As a follow-up, I believe libata-core should be modified to issue the > INITIALIZE DEVICE PARAMETERS command for all CHS devices. > I will work on t

Re: [PATCH libata-dev-2.6 1/3] Add CHS support

2005-02-18 Thread Jeff Garzik
Applied patches 1 and 2 of the first CHS series, and patches 3-1 through 3-3 of the second CHS series, to libata-dev queue. As a follow-up, I believe libata-core should be modified to issue the INITIALIZE DEVICE PARAMETERS command for all CHS devices. Thanks, Jeff - To unsubscribe from

Re: [PATCH libata-dev-2.6 1/3] Add CHS support

2005-02-14 Thread Albert Lee
> 2) Patch #3 needs to be split up into three patches: > a) rename variables (s/sector/block/), > b) reorganize read/write translation > c) add CHS support > Patch 3-3: - add CHS support to ata_scsi_verify_xlat(), ata_scsi_rw_xlat() and ata_scsiop_read_cap(). Albert Signed-off-by: Albe

Re: [PATCH libata-dev-2.6 1/3] Add CHS support

2005-02-14 Thread Albert Lee
> 2) Patch #3 needs to be split up into three patches: > a) rename variables (s/sector/block/), > b) reorganize read/write translation > c) add CHS support > Patch 3-2: - reorganize read/write translation in ata_scsi_rw_xlat() Albert Signed-off-by: Albert Lee <[EMAIL PROTECTED]> --

Re: [PATCH libata-dev-2.6 1/3] Add CHS support

2005-02-14 Thread Albert Lee
Dear all: > > Comments: > > 1) Patches #1 and #2 look OK. > > 2) Patch #3 needs to be split up into three patches: > a) rename variables (s/sector/block/), > b) reorganize read/write translation > c) add CHS support > Happy lunar new year. Attached pls find the split patch #3 for your review

Re: [PATCH libata-dev-2.6 1/3] Add CHS support

2005-02-06 Thread Mark Lord
The exact sequence expected by certain pre-ATA4 (or earlier?) drives was this: SRST RESET IDENTIFY INITIALIZE DRIVE PARAMETERS anything else.. Some drives were very specific about that exact sequence. Nowadays, I don't bother with it for anything new I do, as it is obsolete, and may even get reject

Re: [PATCH libata-dev-2.6 1/3] Add CHS support

2005-02-06 Thread Jeff Garzik
Mark Lord wrote: Jeff Garzik wrote: 3) In Promise's GPL'd driver for their SATA (w/ PATA) cards, they unconditionally execute the INITIALIZE DEVICE PARAMETERS command. I wonder if we should do the same. That command was *necessary* for certain drives at one time, which refused all other command

Re: [PATCH libata-dev-2.6 1/3] Add CHS support

2005-02-06 Thread Mark Lord
Jeff Garzik wrote: 3) In Promise's GPL'd driver for their SATA (w/ PATA) cards, they unconditionally execute the INITIALIZE DEVICE PARAMETERS command. I wonder if we should do the same. That command was *necessary* for certain drives at one time, which refused all other commands until they recei

Re: [PATCH libata-dev-2.6 1/3] Add CHS support

2005-02-05 Thread Jeff Garzik
Thanks for doing this work. Comments: 1) Patches #1 and #2 look OK. 2) Patch #3 needs to be split up into three patches: a) rename variables (s/sector/block/), b) reorganize read/write translation c) add CHS support Otherwise, patch #3 (content-wise) is OK. 3) In Promise'

[PATCH libata-dev-2.6 1/3] Add CHS support

2005-02-05 Thread Albert Lee
Hi Jeff, These are the patches for libata CHS support. Tested OK with my old 1994 ST-5850A hardddisk. Changes: 1. Add the flags, utility function and CHS fields to the and headers. 2. ata_dev_identify() pathed to report and initialize CHS fields in ata_device. ata_qc_new_init() patched