Re: [RESEND PATCH 02/10] ide-floppy: move ide-floppy struct and macro defs into its own header. While at it

2008-01-05 Thread Borislav Petkov
On Fri, Jan 04, 2008 at 11:49:09PM +0100, Bartlomiej Zolnierkiewicz wrote: Hi, Hi Bart, Hmm, contrary to ide-cd.c case there doesn't seem to be a need currently for moving code out of ide-floppy.c (and this patch series doesn't change that). ?, you mean this patch series _does_ change that,

Re: [RESEND PATCH 02/10] ide-floppy: move ide-floppy struct and macro defs into its own header. While at it

2008-01-05 Thread Bartlomiej Zolnierkiewicz
Hi, On Saturday 05 January 2008, Borislav Petkov wrote: On Fri, Jan 04, 2008 at 11:49:09PM +0100, Bartlomiej Zolnierkiewicz wrote: Hi, Hi Bart, Hmm, contrary to ide-cd.c case there doesn't seem to be a need currently for moving code out of ide-floppy.c (and this patch series doesn't

Re: [RESEND PATCH 02/10] ide-floppy: move ide-floppy struct and macro defs into its own header. While at it

2008-01-04 Thread Bartlomiej Zolnierkiewicz
Hi, Hmm, contrary to ide-cd.c case there doesn't seem to be a need currently for moving code out of ide-floppy.c (and this patch series doesn't change that). Besides it would be better to just remove some structs like it has been done with i.e. struct atapi_capabilities_page in ide-cd.c case

[RESEND PATCH 02/10] ide-floppy: move ide-floppy struct and macro defs into its own header. While at it

2008-01-03 Thread Borislav Petkov
- do a white-space cleanup - remove old crufty code untouched since at least 2005 - shorten lines longer than 80ish columns - shorten some LAAARGE typenames. There should be no functional changes resulting from this patch. Signed-off-by: Borislav Petkov [EMAIL PROTECTED] ---