Re: [patch 29/30] sata_nv: don't read shadow registers when in ADMA mode

2007-03-09 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Robert Hancock [EMAIL PROTECTED] Reading from the ATA shadow registers while we are in ADMA mode may cause undefined behavior. Don't read the ATA status register when completing commands for this reason, it shouldn't be needed as the controller will notify us if

Re: [patch 29/30] sata_nv: don't read shadow registers when in ADMA mode

2007-03-09 Thread Robert Hancock
Jeff Garzik wrote: [EMAIL PROTECTED] wrote: From: Robert Hancock [EMAIL PROTECTED] Reading from the ATA shadow registers while we are in ADMA mode may cause undefined behavior. Don't read the ATA status register when completing commands for this reason, it shouldn't be needed as the

Re: [patch 29/30] sata_nv: don't read shadow registers when in ADMA mode

2007-03-09 Thread Alistair John Strachan
On Friday 09 March 2007 14:27, you wrote: Jeff Garzik wrote: [EMAIL PROTECTED] wrote: From: Robert Hancock [EMAIL PROTECTED] Reading from the ATA shadow registers while we are in ADMA mode may cause undefined behavior. Don't read the ATA status register when completing commands for

Re: [patch 29/30] sata_nv: don't read shadow registers when in ADMA mode

2007-03-09 Thread Robert Hancock
Alistair John Strachan wrote: I lean towards yes, since it is a needed-by-hardware fix, but I also am interested in testing feedback since it is so late in the 2.6.21-rc game. I would lean toward that as well, but it would be good to get some testing from some sata_nv ADMA users to make sure it

[patch 29/30] sata_nv: don't read shadow registers when in ADMA mode

2007-03-06 Thread akpm
From: Robert Hancock [EMAIL PROTECTED] Reading from the ATA shadow registers while we are in ADMA mode may cause undefined behavior. Don't read the ATA status register when completing commands for this reason, it shouldn't be needed as the controller will notify us if the command failed. Also,