Andrew, can you fold this into this patch
change to KERN_INFO for failure to set pm policy
Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED]
---
drivers/ata/libata-scsi.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: 2.6-git/drivers/ata/libata-scsi.c
On Thu, 09 Aug 2007 14:24:16 PDT, Kristen Carlson Accardi said:
+++ 2.6-git/drivers/ata/libata-scsi.c
@@ -2904,6 +2976,52 @@ void ata_scsi_simulate(struct ata_device
+ if ((dev-horkage ATA_HORKAGE_IPM) ||
+ !(dev-flags ATA_DFLAG_IPM)) {
+
libata drivers can define a function (enable_pm) that will
perform hardware specific actions to enable whatever power
management policy the user set up from the scsi sysfs
interface if the driver supports it. This power management
policy will be activated after all disks have been
enumerated
Kristen Carlson Accardi wrote:
libata drivers can define a function (enable_pm) that will
perform hardware specific actions to enable whatever power
management policy the user set up from the scsi sysfs
interface if the driver supports it. This power management
policy will be activated
On 8/1/07, Tejun Heo [EMAIL PROTECTED] wrote:
+ if (ata_id_has_hipm(dev-id) || ata_id_has_dipm(dev-id))
+ dev-flags |= ATA_DFLAG_IPM;
Is it safe to use ALPM on a device which only claims to support DIPM?
I have tested on a Dell Inspiron 6400, it has ICH7-M (82801GBM) chipset.
On Wed, 01 Aug 2007 17:27:39 +0900
Tejun Heo [EMAIL PROTECTED] wrote:
Kristen Carlson Accardi wrote:
snippy
Is it safe to use ALPM on a device which only claims to support DIPM?
Yes - I doubled checked this with the AHCI people - and of course you
have Edvin's testing to prove it does fine.
Kristen Carlson Accardi wrote:
On Wed, 01 Aug 2007 17:27:39 +0900
Tejun Heo [EMAIL PROTECTED] wrote:
Kristen Carlson Accardi wrote:
snippy
Is it safe to use ALPM on a device which only claims to support DIPM?
Yes - I doubled checked this with the AHCI people - and of course you
have
libata drivers can define a function (enable_pm) that will
perform hardware specific actions to enable whatever power
management policy the user set up from the scsi sysfs
interface if the driver supports it. This power management
policy will be activated after all disks have been
enumerated
On Thu, 5 Jul 2007 13:05:30 -0700
Kristen Carlson Accardi [EMAIL PROTECTED] wrote:
+ ATA_DFLAG_IPM = (1 6), /* device supports interface PM */
ATA_DFLAG_CFG_MASK = (1 8) - 1,
I had to bump this to (17), so we've run out.
-
To unsubscribe from this list: send the line
On Thu, 5 Jul 2007 15:33:34 -0700
Andrew Morton [EMAIL PROTECTED] wrote:
On Thu, 5 Jul 2007 13:05:30 -0700
Kristen Carlson Accardi [EMAIL PROTECTED] wrote:
+ ATA_DFLAG_IPM = (1 6), /* device supports interface PM */
ATA_DFLAG_CFG_MASK = (1 8) - 1,
I had to bump
On Thu, 05 Jul 2007 20:02:08 -0400
Jeff Garzik [EMAIL PROTECTED] wrote:
May I assume that I may delete the patches from Kristen, and assume that
you will resend an updated version of her AN and ALPM patches to me?
Sure. But I have a sneaking feeling that Kristen sneaks sneaky fixes into
Andrew Morton wrote:
On Thu, 5 Jul 2007 13:05:30 -0700
Kristen Carlson Accardi [EMAIL PROTECTED] wrote:
+ ATA_DFLAG_IPM = (1 6), /* device supports interface PM */
ATA_DFLAG_CFG_MASK = (1 8) - 1,
I had to bump this to (17), so we've run out.
You can shuffle
Andrew Morton wrote:
I guess we can bump ATA_DFLAG_CFG_MASK up to 12, like this?
Yep
Jeff
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
13 matches
Mail list logo
