Re: [patch ide-dev 1/9] use struct ata_taskfile in ide_task_t

2005-02-28 Thread Bartlomiej Zolnierkiewicz
> On Thu, Feb 24, 2005 at 03:36:44PM +0100, Bartlomiej Zolnierkiewicz wrote: > > + tf->device = 0x40; > > Wouldn't ATA_LBA be clearer? I will change it, thanks. - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL PROTECTED] More majordomo in

Re: [patch ide-dev 1/9] use struct ata_taskfile in ide_task_t

2005-02-26 Thread Tejun Heo
Hello, Bartlomiej. Neat patch. Codes look much better now. :-) On Thu, Feb 24, 2005 at 03:36:44PM +0100, Bartlomiej Zolnierkiewicz wrote: > > * use struct ata_taskfile instead of .flags, > .tfRegister[] and .hobRegister[] in ide_task_t > * add #ifndef __KERNEL__ around definitions of {task,

[patch ide-dev 1/9] use struct ata_taskfile in ide_task_t

2005-02-24 Thread Bartlomiej Zolnierkiewicz
* use struct ata_taskfile instead of .flags, .tfRegister[] and .hobRegister[] in ide_task_t * add #ifndef __KERNEL__ around definitions of {task,hob}_struct_t * don't set write-only .hobRegister[6] and .hobRegister[7] in idedisk_set_max_address_ext() * remove no longer needed IDE_CONTROL_OFFSE