Re: Another libata TODO item

2005-08-24 Thread Jeff Garzik
Roland Dreier wrote: Jeff> Look at net drivers. Theres no real infrastructure beyond Jeff> bit tests and printks. I wouldn't call that a subsystem, Jeff> so, I wouldn't call this one such either. Well, scsi_logging.h isn't much of a subsystem either. You obviously did not grep fo

Re: Another libata TODO item

2005-08-24 Thread Roland Dreier
Jeff> Look at net drivers. Theres no real infrastructure beyond Jeff> bit tests and printks. I wouldn't call that a subsystem, Jeff> so, I wouldn't call this one such either. Well, scsi_logging.h isn't much of a subsystem either. - R. - To unsubscribe from this list: send the line

Re: Another libata TODO item

2005-08-24 Thread Jeff Garzik
Roland Dreier wrote: Jeff> In any case, I also contine to be skeptical of in-kernel Jeff> logging subsystems. Aren't you proposing a libata logging subsystem? Look at net drivers. Theres no real infrastructure beyond bit tests and printks. I wouldn't call that a subsystem, so, I wou

Re: Another libata TODO item

2005-08-24 Thread Roland Dreier
Jeff> In any case, I also contine to be skeptical of in-kernel Jeff> logging subsystems. Aren't you proposing a libata logging subsystem? - R. - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: Another libata TODO item

2005-08-24 Thread Jeff Garzik
Christoph Hellwig wrote: On Wed, Aug 24, 2005 at 02:17:11AM -0400, Jeff Garzik wrote: To make libata debugging easier and more fine-grained, we should convert DPRINTK/VPRINTK calls in libata to code that looks like if (ata_msg_xxx(ap->msg_enable)) printk(...) Would b

Re: Another libata TODO item

2005-08-24 Thread Christoph Hellwig
On Wed, Aug 24, 2005 at 02:17:11AM -0400, Jeff Garzik wrote: > > Difficulty: beginner / intermediate > > Modern network drivers have a per-NIC list of debugging messages that > can be enabled/disabled at runtime, implemented as a bitmask named > 'msg_enable' in each driver. VERY useful for tr

Another libata TODO item

2005-08-23 Thread Jeff Garzik
Difficulty: beginner / intermediate Modern network drivers have a per-NIC list of debugging messages that can be enabled/disabled at runtime, implemented as a bitmask named 'msg_enable' in each driver. VERY useful for tracing specific events during debugging. grep for 'msg_enable', 'netif_