Re: pci_get_device_reverse(), why does Calgary need this?

2008-02-16 Thread Muli Ben-Yehuda
On Fri, Feb 15, 2008 at 10:28:22AM -0800, Greg KH wrote: > That would be nice. Muli, want to make a patch for this? Sure, I'll put something together. Cheers, Muli - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL PROTECTED] More majordomo

Re: pci_get_device_reverse(), why does Calgary need this?

2008-02-15 Thread Greg KH
On Fri, Feb 15, 2008 at 04:31:40PM +0100, Sam Ravnborg wrote: > On Fri, Feb 15, 2008 at 07:20:08AM -0800, Greg KH wrote: > > On Fri, Feb 15, 2008 at 09:48:27AM +0200, Muli Ben-Yehuda wrote: > > > In conclusion, our usage doesn't seem lika a good fit for the probe > > > approach, although it could p

Re: pci_get_device_reverse(), why does Calgary need this?

2008-02-15 Thread yong xue
2008/2/15, Sam Ravnborg <[EMAIL PROTECTED]>: > On Fri, Feb 15, 2008 at 07:20:08AM -0800, Greg KH wrote: > > On Fri, Feb 15, 2008 at 09:48:27AM +0200, Muli Ben-Yehuda wrote: > > > In conclusion, our usage doesn't seem lika a good fit for the probe > > > approach, although it could probably conver

Re: pci_get_device_reverse(), why does Calgary need this?

2008-02-15 Thread Sam Ravnborg
On Fri, Feb 15, 2008 at 07:20:08AM -0800, Greg KH wrote: > On Fri, Feb 15, 2008 at 09:48:27AM +0200, Muli Ben-Yehuda wrote: > > In conclusion, our usage doesn't seem lika a good fit for the probe > > approach, although it could probably converted provided we got the > > ordering right with regards

Re: pci_get_device_reverse(), why does Calgary need this?

2008-02-15 Thread Greg KH
On Fri, Feb 15, 2008 at 09:48:27AM +0200, Muli Ben-Yehuda wrote: > In conclusion, our usage doesn't seem lika a good fit for the probe > approach, although it could probably converted provided we got the > ordering right with regards to regular PCI device > initialization. Doesn't seem to be worth

Re: pci_get_device_reverse(), why does Calgary need this?

2008-02-14 Thread Muli Ben-Yehuda
On Thu, Feb 14, 2008 at 11:17:03PM -0800, Greg KH wrote: > Hm, that's wierd. I thought I got something, until I realized that > you are doing a lot of logic before you ever even determine that > your hardware is present in the system. Why are you calling > calgary_locate_bbars() and doing all of

Re: pci_get_device_reverse(), why does Calgary need this?

2008-02-14 Thread Greg KH
On Wed, Feb 13, 2008 at 10:14:59AM -0800, Greg KH wrote: > On Wed, Feb 13, 2008 at 07:47:11PM +0200, Muli Ben-Yehuda wrote: > > On Wed, Feb 13, 2008 at 09:32:03AM -0800, Greg KH wrote: > > > > > Is there some reason you aren't using the "real" PCI driver api here > > > and registering a pci driver

Re: pci_get_device_reverse(), why does Calgary need this?

2008-02-14 Thread Sergei Shtylyov
From: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> Subject: [PATCH] ide: mark "ide=reverse" option as obsolete - it is valid only if "Probe IDE PCI devices in the PCI bus order (DEPRECATED)" config option is used - Greg needs to remove pci_get_device_reverse() for PCI core changes Cc:

Re: pci_get_device_reverse(), why does Calgary need this?

2008-02-13 Thread Greg KH
On Thu, Feb 14, 2008 at 01:02:55AM +0100, Bartlomiej Zolnierkiewicz wrote: > On Thursday 14 February 2008, Greg KH wrote: > > On Wed, Feb 13, 2008 at 11:20:36PM +0100, Bartlomiej Zolnierkiewicz wrote: > > > On Wednesday 13 February 2008, Greg KH wrote: > > > > On Wed, Feb 13, 2008 at 09:28:24AM -08

Re: pci_get_device_reverse(), why does Calgary need this?

2008-02-13 Thread Bartlomiej Zolnierkiewicz
On Thursday 14 February 2008, Greg KH wrote: > On Wed, Feb 13, 2008 at 11:20:36PM +0100, Bartlomiej Zolnierkiewicz wrote: > > On Wednesday 13 February 2008, Greg KH wrote: > > > On Wed, Feb 13, 2008 at 09:28:24AM -0800, Greg KH wrote: > > > > On Wed, Feb 13, 2008 at 01:34:12PM +0100, Bartlomiej Zol

Re: pci_get_device_reverse(), why does Calgary need this?

2008-02-13 Thread Greg KH
On Wed, Feb 13, 2008 at 11:20:36PM +0100, Bartlomiej Zolnierkiewicz wrote: > On Wednesday 13 February 2008, Greg KH wrote: > > On Wed, Feb 13, 2008 at 09:28:24AM -0800, Greg KH wrote: > > > On Wed, Feb 13, 2008 at 01:34:12PM +0100, Bartlomiej Zolnierkiewicz wrote: > > > > On Wednesday 13 February 2

Re: pci_get_device_reverse(), why does Calgary need this?

2008-02-13 Thread Bartlomiej Zolnierkiewicz
On Wednesday 13 February 2008, Greg KH wrote: > On Wed, Feb 13, 2008 at 09:28:24AM -0800, Greg KH wrote: > > On Wed, Feb 13, 2008 at 01:34:12PM +0100, Bartlomiej Zolnierkiewicz wrote: > > > On Wednesday 13 February 2008, Greg KH wrote: > > > > On Wed, Feb 13, 2008 at 02:17:37AM +, Alan Cox wrot

Re: pci_get_device_reverse(), why does Calgary need this?

2008-02-13 Thread Greg KH
On Wed, Feb 13, 2008 at 09:28:24AM -0800, Greg KH wrote: > On Wed, Feb 13, 2008 at 01:34:12PM +0100, Bartlomiej Zolnierkiewicz wrote: > > On Wednesday 13 February 2008, Greg KH wrote: > > > On Wed, Feb 13, 2008 at 02:17:37AM +, Alan Cox wrote: > > > > > Why does the calgary driver need this? C

Re: pci_get_device_reverse(), why does Calgary need this?

2008-02-13 Thread Greg KH
On Wed, Feb 13, 2008 at 07:47:11PM +0200, Muli Ben-Yehuda wrote: > On Wed, Feb 13, 2008 at 09:32:03AM -0800, Greg KH wrote: > > > Is there some reason you aren't using the "real" PCI driver api here > > and registering a pci driver for these devices? That would take the > > whole "loop over all p

Re: pci_get_device_reverse(), why does Calgary need this?

2008-02-13 Thread Muli Ben-Yehuda
On Wed, Feb 13, 2008 at 09:32:03AM -0800, Greg KH wrote: > Is there some reason you aren't using the "real" PCI driver api here > and registering a pci driver for these devices? That would take the > whole "loop over all pci devices" logic out of the code entirely. I recall we had a reason, but

Re: pci_get_device_reverse(), why does Calgary need this?

2008-02-13 Thread Greg KH
On Wed, Feb 13, 2008 at 01:34:12PM +0100, Bartlomiej Zolnierkiewicz wrote: > On Wednesday 13 February 2008, Greg KH wrote: > > On Wed, Feb 13, 2008 at 02:17:37AM +, Alan Cox wrote: > > > > Why does the calgary driver need this? Can we just use pci_get_device() > > > > instead? Why do you need

Re: pci_get_device_reverse(), why does Calgary need this?

2008-02-13 Thread Greg KH
On Wed, Feb 13, 2008 at 11:32:26AM +0200, Muli Ben-Yehuda wrote: > On Tue, Feb 12, 2008 at 04:16:38PM -0800, Greg KH wrote: > > > Why does the calgary driver need this? Can we just use > > pci_get_device() instead? Why do you need to walk the device list > > backwards? Do you get false positive

Re: pci_get_device_reverse(), why does Calgary need this?

2008-02-13 Thread Bartlomiej Zolnierkiewicz
On Wednesday 13 February 2008, Greg KH wrote: > On Wed, Feb 13, 2008 at 02:17:37AM +, Alan Cox wrote: > > > Why does the calgary driver need this? Can we just use pci_get_device() > > > instead? Why do you need to walk the device list backwards? Do you get > > > false positives going forward

Re: pci_get_device_reverse(), why does Calgary need this?

2008-02-13 Thread Muli Ben-Yehuda
On Tue, Feb 12, 2008 at 04:16:38PM -0800, Greg KH wrote: > Why does the calgary driver need this? Can we just use > pci_get_device() instead? Why do you need to walk the device list > backwards? Do you get false positives going forward? It's not strictly needed, we used it for symmetry. Feel f

Re: pci_get_device_reverse(), why does Calgary need this?

2008-02-12 Thread Greg KH
On Wed, Feb 13, 2008 at 02:17:37AM +, Alan Cox wrote: > > Why does the calgary driver need this? Can we just use pci_get_device() > > instead? Why do you need to walk the device list backwards? Do you get > > false positives going forward? > > It doesn't look to be performance critical so t

Re: pci_get_device_reverse(), why does Calgary need this?

2008-02-12 Thread Alan Cox
> Why does the calgary driver need this? Can we just use pci_get_device() > instead? Why do you need to walk the device list backwards? Do you get > false positives going forward? It doesn't look to be performance critical so the driver can pci_get_device until the end and use the final hit any