Re: Why we were seeing so many spurious NCQ completions

2007-12-06 Thread Jeff Garzik
Tejun Heo wrote: Hello, all. This has been going on for quite some time now but I finally succeeded to reproduce the problem and find out what has been going on. It wasn't drive's or controller's fault. The spurious completion detection logic was wrong which makes all of this my fault. :-)

Why we were seeing so many spurious NCQ completions

2007-12-06 Thread Tejun Heo
Hello, all. This has been going on for quite some time now but I finally succeeded to reproduce the problem and find out what has been going on. It wasn't drive's or controller's fault. The spurious completion detection logic was wrong which makes all of this my fault. :-) The attached patch