Re: readXs on pci*iomap-ped regions [Was: [PATCH] /drivers/char sx.c ioremap -> pci_ioremap api]

2007-08-25 Thread Alan Cox
On Sat, 25 Aug 2007 04:56:19 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > If the driver knows its MMIO, using readX/writeX after pci_iomap() is > just fine, for all current implementations, and it makes sense that way. There is nothing that guarantees this is permitted, any more than there is

Re: readXs on pci*iomap-ped regions [Was: [PATCH] /drivers/char sx.c ioremap -> pci_ioremap api]

2007-08-25 Thread Jiri Slaby
Jeff Garzik napsal(a): > If the driver knows its MMIO, using readX/writeX after pci_iomap() is > just fine, for all current implementations, and it makes sense that way. Hmm, that's what I'm claiming. -- Jiri Slaby ([EMAIL PROTECTED]) Faculty of Informatics, Masaryk University - To unsubscribe f

Re: readXs on pci*iomap-ped regions [Was: [PATCH] /drivers/char sx.c ioremap -> pci_ioremap api]

2007-08-25 Thread Jeff Garzik
If the driver knows its MMIO, using readX/writeX after pci_iomap() is just fine, for all current implementations, and it makes sense that way. Jeff - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL PROTECTED] More majordomo info

readXs on pci*iomap-ped regions [Was: [PATCH] /drivers/char sx.c ioremap -> pci_ioremap api]

2007-08-25 Thread Jiri Slaby
Alan Cox napsal(a): > + rebase = pci_iomap(pdev, 0, 0x80); > t = readl(rebase + CNTRL_REG_OFFSET); >>> Switch to ioread* if you are using the iomap interface. Its not a trivial >> Why, if you know it's surely a mem region (and thus you rely on it and do >> ioremap)? There are many