Re: sata_sil 3112 activity LED patch

2005-07-07 Thread Aric Cyr
On Thu, Jul 07, 2005 at 02:47:03PM +0200, Jens Axboe wrote: On Wed, Jul 06 2005, Jeff Garzik wrote: I don't think its ugly, necessarily. I do worry about the flash memory stuff, though, which is why I don't want to merge this upstream for now. For your patch specifically, it would be

Re: sata_sil 3112 activity LED patch

2005-07-07 Thread Jens Axboe
On Wed, Jul 06 2005, Jeff Garzik wrote: Aric Cyr wrote: After finally getting fed up with not having my activity light working for my SATA drives, I came up with a small patch (more like hack) to make it work. It works quite well, but I'm afraid that there are many restriction that this

Re: sata_sil 3112 activity LED patch

2005-07-07 Thread Jens Axboe
On Thu, Jul 07 2005, Aric Cyr wrote: There's also an existing variant of this in the block layer, the activity_fn, that we use on the ibook/powerbook to use the sleep led as an activity light. Just in case you prefer that to overloading the bmdma start/stop handlers. You suggestion at

Re: sata_sil 3112 activity LED patch

2005-07-06 Thread Jeff Garzik
Aric Cyr wrote: After finally getting fed up with not having my activity light working for my SATA drives, I came up with a small patch (more like hack) to make it work. It works quite well, but I'm afraid that there are many restriction that this patch does not check for that it probably

sata_sil 3112 activity LED patch

2005-07-05 Thread Aric Cyr
After finally getting fed up with not having my activity light working for my SATA drives, I came up with a small patch (more like hack) to make it work. It works quite well, but I'm afraid that there are many restriction that this patch does not check for that it probably should... so consider